Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add hemlfile and cloudformation linters #53

Merged
merged 9 commits into from
Mar 30, 2023
Merged

feat: add hemlfile and cloudformation linters #53

merged 9 commits into from
Mar 30, 2023

Conversation

dragonraid
Copy link
Contributor

@dragonraid dragonraid commented Mar 28, 2023 •
edited
Loading

Adding workflows for helmfile and cloudformation linting

@github-actions github-actions bot added this to the 60th sprint - Platform team milestone Mar 28, 2023
@github-actions github-actions bot added the t-platform Issues with this label are in the ownership of the platform team. label Mar 28, 2023
github-actions[bot]
github-actions bot reviewed Mar 28, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

None of the pull request and linked issue has estimate

@dragonraid dragonraid marked this pull request as ready for review March 28, 2023 11:47
drobnikj
drobnikj approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@drobnikj drobnikj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it work for GitHub workflows yamls as well? If so I would add it into this repo.
Then you can lint linting works with linting workflow. :D

@dragonraid
Copy link
Contributor Author

Will it work for GitHub workflows yamls as well? If so I would add it into this repo. Then you can lint linting works with linting workflow. :D

Good point there is https://github.com/rhysd/actionlint for gh actions. I'll add it.

@dragonraid dragonraid merged commit a1eb3e4 into main Mar 30, 2023
@dragonraid dragonraid deleted the feat/linters branch March 30, 2023 11:27
@github-actions github-actions bot mentioned this pull request Mar 30, 2023
Merged
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@drobnikj drobnikj drobnikj approved these changes

@lukasmrtvy lukasmrtvy Awaiting requested review from lukasmrtvy

Assignees

@dragonraid dragonraid

Labels
t-platform Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Milestone
60th sprint - Platform team
Development

Successfully merging this pull request may close these issues.
3 participants
@dragonraid @drobnikj @fnesveda