Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add secrets env vars to build workflow #68

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Conversation

dragonraid
Copy link
Contributor

@dragonraid dragonraid commented Jun 19, 2023

This PR adds support for passing secret file https://docs.docker.com/engine/reference/commandline/buildx_build/#secret.

This file contains comma-delimited secret KEY=VALUE pair, that can be source in Dockerfile like this:

RUN --mount=type=secret,id=SECRET_ENV_VARS,target=/run/secrets/SECRET_ENV_VARS \
    . /run/secrets/SECRET_ENV_VARS && <my_command_using_secret(s)>

@github-actions github-actions bot added this to the 66th sprint - Platform team milestone Jun 19, 2023
@github-actions github-actions bot added the t-platform Issues with this label are in the ownership of the platform team. label Jun 19, 2023
@dragonraid dragonraid requested a review from drobnikj June 19, 2023 13:24
@dragonraid dragonraid merged commit 408f4fa into main Jun 19, 2023
@dragonraid dragonraid deleted the feat/secrets branch June 19, 2023 13:34
@github-actions github-actions bot mentioned this pull request Jun 19, 2023
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-platform Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants