Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate H1 headers #296

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fix duplicate H1 headers #296

merged 1 commit into from
Oct 12, 2023

Conversation

szekelyzol
Copy link
Contributor

Changes are for this Asana task.

Summary:

  • Updated each affected page to only have one H1 header and bumped header levels accordingly
  • Fixed typos (for example instanciation -> instantiation)
  • Fixed table formatting for some SKDs for better readability
  • Removed duplicate table of contents sections (Doctave generates a table of contents for each page, no need to define one in the page body)

@szekelyzol szekelyzol added the documentation Improvements or additions to documentation label Oct 12, 2023
@szekelyzol szekelyzol merged commit 031c50f into main Oct 12, 2023
27 of 28 checks passed
@szekelyzol szekelyzol deleted the Fix-duplicate-H1-headers branch October 12, 2023 12:16
arthemium
arthemium approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@arthemium arthemium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need to change the same things in the readme.md of each of the SDK

templates/documentation/delivery-analytics/analytics.md Show resolved Hide resolved
templates/documentation/sdks/player/apivideo-android-player-analytics.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivier-lando olivier-lando olivier-lando approved these changes

@arthemium arthemium arthemium approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szekelyzol @arthemium @olivier-lando