-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analytics updates #403
Analytics updates #403
Conversation
olivier-lando
commented
Oct 25, 2024
•
edited by szekelyzol
Loading
edited by szekelyzol
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1208145821422434
2995a62
to
a496a99
Compare
oas_apivideo.yaml
Outdated
- `true` means that a single user watchig multiple times counts as 1 unique viewer | ||
- `false` means that all views count, even if from the same user. | ||
|
||
The API accepts this parameter only when you use the `ccv-peak`, `ccv-average`, or `view` metric. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this description applies to metrics routes too, but if so, maybe you should also list the ccv
metric?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, fixed! For this route, the sentence should be:
The API accepts this parameter only when you use the
ccv
orview
metric.
oas_apivideo.yaml
Outdated
TODO | ||
Use this query parameter to define how many seconds a view has to last to be counted in analytics data. | ||
|
||
- You can only use this parameter together with the `view` metric. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove the with maybe?
"You can only use this parameter with the view
metric."
Or maybe "You can only use this parameter along the view
metric." ?
(i'm forgetting how to English)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed: removed "together".
oas_apivideo.yaml
Outdated
@@ -13335,7 +13365,7 @@ paths: | |||
- `device-type`: Returns analytics based on the type of device used by the viewers. Response values can include: `computer`, `phone`, `tablet`, `tv`, `console`, `wearable`, `unknown`. | |||
- `operating-system`: Returns analytics based on the operating system used by the viewers. Response values can include `windows`, `mac osx`, `android`, `ios`, `linux`. | |||
- `browser`: Returns analytics based on the browser used by the viewers. Response values can include `chrome`, `firefox`, `edge`, `opera`. | |||
- `referrer`: TODO | |||
- `referrer`: Returns the URL where the view originates from, for example a website where the video is embedded. View events from Android and iOS return empty strings as referrer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last sentence should maybe be: "View events from Android and iOS return empty strings as the [or a] referrer."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed as:
View events from Android and iOS return empty strings as the value for
referrer
.
oas_apivideo.yaml
Outdated
TODO | ||
Use this query parameter to control how viewer data is counted: | ||
|
||
- `true` means that a single user watchig multiple times counts as 1 unique viewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
watching
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed ✅
oas_apivideo.yaml
Outdated
TODO | ||
Use this query parameter to control how viewer data is counted: | ||
|
||
- `true` means that a single user watchig multiple times counts as 1 unique viewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
watching
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed ✅
oas_apivideo.yaml
Outdated
|
||
- If you do not set a value for `interval`, and the period you set using the `from` and `to` parameters is less than or equals to 2 days, then the default assigned value is `hour`. Otherwise the API sets it to `day`. | ||
- When you set `minute` as interval, the timeframe you define with the `from` and `to` parameters should be less than 60 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"must be" instead of "should be"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected to must
@@ -17004,6 +17148,7 @@ components: | |||
- `operatingSystem`: Returns analytics based on the operating system used by the viewers. Response values can include `windows`, `mac osx`, `android`, `ios`, `linux`. | |||
- `browser`: Returns analytics based on the browser used by the viewers. Response values can include `chrome`, `firefox`, `edge`, `opera`. | |||
- `tag`: Returns analytics for videos using this tag. This filter only accepts a single value and is case sensitive. Read more about tagging your videos [here](https://docs.api.video/vod/tags-metadata). | |||
- `referrer`: Filters data based on the URL where the view is originating from. Accepts an empty string as a value to filter view events where no referrer is available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's worth specifying two things:
- this is an exact match; even forgetting a slash (for example) at the end of the referrer string will end up in no results showing up
- the value of this filter needs to be URL encoded; for example https%3A%2F%2Fmy-awesome-videos.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added missing specifications. Thanks Mio!