[Feature] Addition of support to mirroring of the video capture #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh sorry, I missed your PR. On iOS, the front camera is always mirrored. I thought this was your requirement. In what use case, do you have to mirror or not the video? |
|
@ThibaultBee Here is the write-up on explanation of the use-case |
|
As far as I understand, you just need to mirror front cameras which is already the case in this project (not on Android yet). So, the addition of an API to enable/disable mirroring does not seem usefull. Am I missing something? Do you need what is in the PR? If you don't need this API, I will close the PR (not merge it). |
|
Rejected as we force the mirror for front camera now: see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new feature to expose the ability to mirror the video capture stream. This does not change any default or existing behavior.