Enhance buildDockerImage error handling and include all context files #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows builds with an explicit
Dockerfile
to include files from the build context. The build process now includes all files in the specified build context directory. This is because Dockerode already respects the.dockerignore
file, which means that while unnecessary files are filtered out, all relevant files must be present in the context for a successful build.For example if you try to copy a script into the Docker image while using an explicit
Dockerfile
you would get this error:{"errorDetail":{"message":"COPY failed: file not found in build context or excluded by .dockerignore: stat config.sh: file does not exist"},"error":"COPY failed: file not found in build context or excluded by .dockerignore: stat config.sh: file does not exist"}
This also addresses issues related to error handling in the
buildDockerImage
function within thelib/servicesTools.js
file. Previously, errors during the Docker image build process were failing silently, making it difficult to diagnose problems. This update enhances error detection and ensures that all relevant files in the build context directory are included in the build process.