Better tests.

onep/commands/vaults.py

@@ -1,7 +1,7 @@
 import json
 import sys
 
-from ..util import fatal, run, create_table
+from ..util import exit, fatal, run, create_table
 
 
 def vaults(session: str, to_json: bool) -> None:

tests/test_error.py

@@ -0,0 +1,18 @@
+import pytest
+import mock
+
+from onep.onep import main
+
+
+@mock.patch("onep.onep.check_session", return_value="dummysession")
+@mock.patch("onep.util.load_session", return_value="dummysession")
+@mock.patch("onep.commands.vaults.run", return_value=(False, "", "dummy error from upstream"))
+def test_error(a, b, c, capsys):
+    with pytest.raises(SystemExit) as e:
+        main(["personal", "vaults"])
+
+    output = capsys.readouterr().err
+
+    assert e.value.code == 1
+    assert "ERROR:" in output
+    assert "dummy error from upstream" in output

tests/test_vaults.py

@@ -7,11 +7,14 @@
 @mock.patch("onep.onep.check_session", return_value="dummysession")
 @mock.patch("onep.util.load_session", return_value="dummysession")
 @mock.patch("onep.commands.vaults.run", return_value=(True, "{}", ""))
-def test_no_vaults(a, b, c):
+def test_no_vaults(a, b, c, capsys):
     with pytest.raises(SystemExit) as e:
         main(["personal", "vaults"])
 
-    assert "There are no vaults in this account." in str(e.value)
+    output = capsys.readouterr().err
+
+    assert e.value.code == 0
+    assert "There are no vaults in this account." in output
 
 
 TWO_VAULTS_OUTPUT = """[{"id": "vault1", "name": "First vault"}, {"id": "vault2", "name": "Second vault"}]"""