Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProviderManager初始化动作不再在构造方法中实现 #50

Merged
merged 10 commits into from
Jan 21, 2024

Conversation

s281542686
Copy link
Contributor

What's the purpose of this PR

ProviderManager初始化动作不再在构造方法中实现

Brief changelog

新增com.ctrip.framework.foundation.spi.ProviderManager.initialize方法,在使用自定义的ProviderManager实现时,不再因自动初始化com.ctrip.framework.foundation.internals.DefaultProviderManager和com.ctrip.framework.foundation.internals.NullProviderManager,而打印干扰日志

…自定义的ProviderManager实现时,不再因自动初始化com.ctrip.framework.foundation.internals.DefaultProviderManager和com.ctrip.framework.foundation.internals.NullProviderManager,而打印干扰日志
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 12, 2024
Copy link

github-actions bot commented Jan 12, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ce881f5) 68.59% compared to head (667f4ce) 68.58%.

Files Patch % Lines
...trip/framework/foundation/spi/ProviderManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #50      +/-   ##
============================================
- Coverage     68.59%   68.58%   -0.01%     
- Complexity     1206     1207       +1     
============================================
  Files           171      171              
  Lines          5196     5198       +2     
  Branches        561      561              
============================================
+ Hits           3564     3565       +1     
- Misses         1371     1372       +1     
  Partials        261      261              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the CHANGES.md

…自定义的ProviderManager实现时,不再因自动初始化com.ctrip.framework.foundation.internals.DefaultProviderManager和com.ctrip.framework.foundation.internals.NullProviderManager,而打印干扰日志
@s281542686
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

CHANGES.md Outdated Show resolved Hide resolved
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 21, 2024
@nobodyiam nobodyiam merged commit 51efea6 into apolloconfig:main Jan 21, 2024
7 of 9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2024
@nobodyiam nobodyiam added this to the 2.3.0 milestone Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants