-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProviderManager初始化动作不再在构造方法中实现 #50
Conversation
…自定义的ProviderManager实现时,不再因自动初始化com.ctrip.framework.foundation.internals.DefaultProviderManager和com.ctrip.framework.foundation.internals.NullProviderManager,而打印干扰日志
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
============================================
- Coverage 68.59% 68.58% -0.01%
- Complexity 1206 1207 +1
============================================
Files 171 171
Lines 5196 5198 +2
Branches 561 561
============================================
+ Hits 3564 3565 +1
- Misses 1371 1372 +1
Partials 261 261 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update the CHANGES.md
apollo-core/src/main/java/com/ctrip/framework/foundation/spi/ProviderManager.java
Outdated
Show resolved
Hide resolved
…自定义的ProviderManager实现时,不再因自动初始化com.ctrip.framework.foundation.internals.DefaultProviderManager和com.ctrip.framework.foundation.internals.NullProviderManager,而打印干扰日志
I have read the CLA Document and I hereby sign the CLA |
apollo-core/src/main/java/com/ctrip/framework/foundation/spi/ProviderManager.java
Outdated
Show resolved
Hide resolved
apollo-core/src/main/java/com/ctrip/framework/foundation/spi/ProviderManager.java
Outdated
Show resolved
Hide resolved
…roviderManager.java Co-authored-by: Jason Song <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
ProviderManager初始化动作不再在构造方法中实现
Brief changelog
新增com.ctrip.framework.foundation.spi.ProviderManager.initialize方法,在使用自定义的ProviderManager实现时,不再因自动初始化com.ctrip.framework.foundation.internals.DefaultProviderManager和com.ctrip.framework.foundation.internals.NullProviderManager,而打印干扰日志