Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement parsing time based on pattern for @ApolloJsonValue #52

Closed
wants to merge 7 commits into from

Conversation

huxleyliau
Copy link
Contributor

@huxleyliau huxleyliau commented Jan 20, 2024

What's the purpose of this PR

Implement parsing time based on pattern for @ApolloJsonValue from #49

Which issue(s) this PR fixes:

Fixes #49

Brief changelog

Make use of Gson's current way of turning a string into a date to make @ApolloJsonValue able to handle time strings according to a given pattern.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 20, 2024
Copy link

github-actions bot commented Jan 20, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@huxleyliau
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ce881f5) 68.59% compared to head (a6aac60) 68.60%.
Report is 1 commits behind head on main.

❗ Current head a6aac60 differs from pull request most recent head 4532209. Consider uploading reports for the commit 4532209 to get more accurate results

Files Patch % Lines
...pring/property/AutoUpdateConfigChangeListener.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #52      +/-   ##
============================================
+ Coverage     68.59%   68.60%   +0.01%     
  Complexity     1206     1206              
============================================
  Files           171      171              
  Lines          5196     5202       +6     
  Branches        561      562       +1     
============================================
+ Hits           3564     3569       +5     
  Misses         1371     1371              
- Partials        261      262       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@huxleyliau huxleyliau closed this Jan 21, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jan 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2024
@nobodyiam nobodyiam reopened this Jan 21, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jan 21, 2024
@nobodyiam
Copy link
Member

recheck

@huxleyliau huxleyliau marked this pull request as draft January 21, 2024 08:43
@huxleyliau huxleyliau marked this pull request as ready for review January 21, 2024 08:51
@nobodyiam nobodyiam closed this Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ApolloJsonValue注解增加部分自定义功能
2 participants