-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement parsing time based on pattern for @ApolloJsonValue #52
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
============================================
+ Coverage 68.59% 68.60% +0.01%
Complexity 1206 1206
============================================
Files 171 171
Lines 5196 5202 +6
Branches 561 562 +1
============================================
+ Hits 3564 3569 +5
Misses 1371 1371
- Partials 261 262 +1 ☔ View full report in Codecov by Sentry. |
...nt/src/main/java/com/ctrip/framework/apollo/spring/annotation/ApolloAnnotationProcessor.java
Outdated
Show resolved
Hide resolved
...ent/src/test/java/com/ctrip/framework/apollo/spring/JavaConfigPlaceholderAutoUpdateTest.java
Outdated
Show resolved
Hide resolved
...ent/src/test/java/com/ctrip/framework/apollo/spring/JavaConfigPlaceholderAutoUpdateTest.java
Outdated
Show resolved
Hide resolved
apollo-client/src/test/java/com/ctrip/framework/apollo/spring/JavaConfigPlaceholderTest.java
Outdated
Show resolved
Hide resolved
# Conflicts: # CHANGES.md
recheck |
What's the purpose of this PR
Implement parsing time based on pattern for @ApolloJsonValue from #49
Which issue(s) this PR fixes:
Fixes #49
Brief changelog
Make use of Gson's current way of turning a string into a date to make @ApolloJsonValue able to handle time strings according to a given pattern.
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.