Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use trigger event with base branch context #592

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

calvincestari
Copy link
Member

I noticed that the 'Check PR Metadata' CI check was not always running or failing with the following error:

GraphQL: Resource not accessible by integration (addComment)

I did some reading and from this issue it seems as if the correct event to base the action on is pull_request_target rather than pull_request because of the need to elevate permissions for the action. The following in the GitHub documentation for pull_request_target is the relevant section:

This event runs in the context of the base of the pull request, rather than in the context of the merge commit, as the pull_request event does.

  • I added the reopened event to the types that would trigger this check too.

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Jan 27, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 22c6c416e5d0eeb0be9ba95b

Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for apollo-ios-docc canceled.

Name Link
🔨 Latest commit e3443b3
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docc/deploys/6797dfa215024e000873b4ca

@calvincestari calvincestari mentioned this pull request Jan 27, 2025
@calvincestari
Copy link
Member Author

Merging without review since this only changes a CI check.

@calvincestari calvincestari changed the title ci: Use event on base branch ci: Use trigger event with base branch context Jan 27, 2025
@calvincestari calvincestari merged commit adbce53 into main Jan 27, 2025
25 checks passed
@calvincestari calvincestari deleted the fix/check-pr-metadata-event branch January 27, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants