-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mutateIfFulfilled functions #608
base: main
Are you sure you want to change the base?
Conversation
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: c0a8e05d612b150d035342c7 |
✅ Deploy Preview for apollo-ios-docc canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will these extensions cover named fragments too?
public var __data: DataDict = .empty() | ||
init(_dataDict: DataDict) { __data = _dataDict } | ||
|
||
static var __selections: [Selection] { [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it matters to this particular test suite but it looks like we're missing the age
selection.
Also, the test failures look like proper errors.
|
This addresses the limitations described in apollographql/apollo-ios#3443. This is solved by adding a new
mutateIfFulfilled
function that only allows for the properties of an inline fragment to be mutated if the fragment already is fulfilled, while still preventing a fragment from being added/removed from an existing model.