Skip to content
This repository was archived by the owner on Oct 30, 2024. It is now read-only.

[TN] Error Status Code 200 #763

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

[TN] Error Status Code 200 #763

wants to merge 12 commits into from

Conversation

burn2delete
Copy link
Contributor

Added TN47 - Error! Status Code 200?

@burn2delete burn2delete requested a review from a team as a code owner February 8, 2024 02:42
Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for apollo-monodocs ready!

Name Link
🔨 Latest commit 153ee1f
🔍 Latest deploy log https://app.netlify.com/sites/apollo-monodocs/deploys/65f87779650d120008c7c76e
😎 Deploy Preview https://deploy-preview-763--apollo-monodocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 27 (🔴 down 41 from production)
Accessibility: 85 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (🟢 up 6 from production)
PWA: 50 (🟢 up 10 from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@burn2delete burn2delete requested a review from smyrick February 8, 2024 18:00
In contrast, REST APIs typically follow a serial execution model, where one failed request can halt the entire process.

Therefore, using HTTP status codes to convey the outcome of parallel GraphQL operations would be impractical and misleading.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need a section calling out when non-200s are used. The GraphQL over http spec allows it and so we don't want some one to take away from the this note that you ALWAYS have to return 200

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants