Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 40 new buffer deprecated #99

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Issue 40 new buffer deprecated #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f09ccc
Fixes #40 - new Buffer is deprecated
JEStaubach Oct 1, 2019
352702b
Convert another use of new Buffer
JEStaubach Oct 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion final/server/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const dataSources = () => ({
const context = async ({ req }) => {
// simple auth check on every request
const auth = (req.headers && req.headers.authorization) || '';
const email = new Buffer(auth, 'base64').toString('ascii');
const email = Buffer.from(auth, 'base64').toString('ascii');

// if the email isn't formatted validly, return null for user
if (!isEmail.validate(email)) return { user: null };
Expand Down
2 changes: 1 addition & 1 deletion final/server/src/resolvers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ module.exports = {
},
login: async (_, { email }, { dataSources }) => {
const user = await dataSources.userAPI.findOrCreateUser({ email });
if (user) return new Buffer(email).toString('base64');
if (user) return Buffer.from(email).toString('base64');
},
},
Launch: {
Expand Down