Skip to content

Commit

Permalink
Upgrade OTel to 0.24 to support Hyper 1 (#6493)
Browse files Browse the repository at this point in the history
Co-authored-by: Bryn Cooke <[email protected]>
Co-authored-by: bryn <[email protected]>
  • Loading branch information
3 people authored Jan 22, 2025
1 parent 53b8502 commit 8d233bb
Show file tree
Hide file tree
Showing 140 changed files with 1,865 additions and 25,053 deletions.
32 changes: 32 additions & 0 deletions .changesets/breaking_tninesling_otel_0_24.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
### Upgrade OTel to support Hyper 1 ([PR #6493](https://github.com/apollographql/router/pull/6493))

Upgrades OpenTelemetry dependencies to support hyper 1. The latest versions of OpenTelemetry do not support legacy Jaeger traces. Users should export OpenTelemetry Protocol (OTLP) traces to Jaeger instead. Note that Jaeger _propagation_ is still supported.

(Deprecated) Legacy Jaeger Exporter:

```yaml
telemetry.exporters.tracing:
propagation:
jaeger: true
jaeger:
enabled: true
batch_processor:
scheduled_delay: 100ms
agent:
endpoint: default
```
(Recommended) OTLP Exporter:
```yaml
telemetry.exporters.tracing:
propagation:
jaeger: true
otlp:
enabled: true
batch_processor:
scheduled_delay: 100ms
endpoint: default
```
By [@tninesling](https://github.com/tninesling) in https://github.com/apollographql/router/pull/6493
2 changes: 1 addition & 1 deletion .changesets/feat_bryn_named_runtime_channel.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
A new metric has been introduced to allow observation of how many spans are being dropped by an telemetry batch processor.

- `apollo.router.telemetry.batch_processor.errors` - The number of errors encountered by exporter batch processors.
- `name`: One of `apollo-tracing`, `datadog-tracing`, `jaeger-collector`, `otlp-tracing`, `zipkin-tracing`.
- `name`: One of `apollo-tracing`, `datadog-tracing`, `otlp-tracing`, `zipkin-tracing`.
- `error` = One of `channel closed`, `channel full`.

By observing the number of spans dropped it is possible to estimate what batch processor settings will work for you.
Expand Down
1 change: 0 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ executors:
docker:
- image: cimg/base:current
- image: cimg/redis:7.4.1
- image: jaegertracing/all-in-one:1.54.0
- image: openzipkin/zipkin:3.4.3
- image: ghcr.io/datadog/dd-apm-test-agent/ddapm-test-agent:v1.17.0
resource_class: 2xlarge
Expand Down
1 change: 1 addition & 0 deletions .gitleaks.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"f12bcddc663aa4c4d90218a1bb718fe74e0e7be3",
"e1e6f93341aea383da2ec6b36a9bfcf7e63a111e",
"e5590027506337381887dadef9baadd063e05830",
"b4fdf65c5eaca08057886e5b30553201302b9764",

# https://github.com/apollographql/router/blob/d826844c8cf433f78938059f02feecc108468e49/licenses.html#L8558
# https://github.com/apollographql/router-private/blob/d826844c8cf433f78938059f02feecc108468e49/licenses.html#L8558
Expand Down
Loading

0 comments on commit 8d233bb

Please sign in to comment.