Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the new CORS behavior #1044

Merged
merged 6 commits into from
May 19, 2022
Merged

Document the new CORS behavior #1044

merged 6 commits into from
May 19, 2022

Conversation

o0Ignition0o
Copy link
Contributor

@o0Ignition0o o0Ignition0o commented May 13, 2022 •
edited
Loading

Fixes #1038

This commit updates the CORS documentation to reflect the recent CORS and CSRF updates.

@netlify
Copy link

netlify bot commented May 13, 2022 •
edited
Loading

✅ Deploy Preview for apollo-router-docs ready!

Name Link
🔨 Latest commit a072dc3
🔍 Latest deploy log https://app.netlify.com/sites/apollo-router-docs/deploys/6285fa3a953b7e0008383d88
😎 Deploy Preview https://deploy-preview-1044--apollo-router-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions

This comment has been minimized.

Sign in to view
@o0Ignition0o o0Ignition0o changed the title wip: cors documentation cors documentation May 17, 2022
@o0Ignition0o o0Ignition0o marked this pull request as ready for review May 17, 2022 08:41
@o0Ignition0o o0Ignition0o self-assigned this May 17, 2022
@o0Ignition0o o0Ignition0o changed the title cors documentation Document the new CORS behavior May 17, 2022
BrynCooke
BrynCooke approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@BrynCooke BrynCooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great docs.
Left a few comments.
Maybe it's be good to introduce some bullets or numbered lists especially in the instructional sections, e.g.

If you want to xxx then:
1.
2.
3.

docs/source/configuration/cors.mdx Outdated Show resolved Hide resolved
docs/source/configuration/cors.mdx Outdated Show resolved Hide resolved
docs/source/configuration/cors.mdx Outdated Show resolved Hide resolved
docs/source/configuration/cors.mdx Outdated Show resolved Hide resolved
docs/source/configuration/cors.mdx Outdated Show resolved Hide resolved
@o0Ignition0o o0Ignition0o merged commit 0684d1f into main May 19, 2022
@o0Ignition0o o0Ignition0o deleted the igni/cors_docs branch May 19, 2022 08:45
@BrynCooke BrynCooke added this to the v0.9.1 milestone May 20, 2022
@BrynCooke BrynCooke mentioned this pull request May 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrynCooke BrynCooke BrynCooke approved these changes

@StephenBarlow StephenBarlow Awaiting requested review from StephenBarlow

@garypen garypen Awaiting requested review from garypen

@abernix abernix Awaiting requested review from abernix

@bnjjj bnjjj Awaiting requested review from bnjjj

@Geal Geal Awaiting requested review from Geal

@SimonSapin SimonSapin Awaiting requested review from SimonSapin

Assignees

@o0Ignition0o o0Ignition0o

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CORS plugin: Update documentation
2 participants
@o0Ignition0o @BrynCooke