-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(federation): sketch a query completeness correctness check #6231
base: dev
Are you sure you want to change the base?
Conversation
✅ Docs Preview ReadyNo new or changed pages found. |
@goto-bus-stop, please consider creating a changeset entry in |
CI performance tests
|
Wondering whether |
I expect it will be useful to have the |
This PR sketches out one way to do a correctness check from when I was working on it, asserting that all the paths requested by the supergraph operation are executed by the query plan. It uses this check on all operations planned in tests.
This is not a complete completeness check and has several limitations that are mentioned in the code comments (and probably some that aren't), but it might hopefully serve as a basis for discussion about what else to do!
It also needs eg. a way to handle
@skip
/@include
conditionals. I think those could be encoded in path elements in this approach.