-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove experimental_when_header feature #6285
base: next
Are you sure you want to change the base?
Conversation
Signed-off-by: Benjamin <[email protected]>
✅ Docs Preview ReadyConfiguration{
"repoOverrides": {
"apollographql/router@next": {
"remote": {
"owner": "apollographql",
"repo": "router",
"branch": "bnjjj/fix_786"
}
}
}
}
1 pages published. Build will be available for 30 days. |
CI performance tests
|
@abernix Yes. Do we have an existing one somewhere ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs an entry in the migration guide.
Signed-off-by: Benjamin <[email protected]>
@@ -89,6 +89,7 @@ The subgraph service executes multiple times during query execution, with each e | |||
| `supergraph_operation_kind` | Yes | `string` | The operation kind from the supergraph query | | |||
| `supergraph_query` | Yes | `string` | The graphql query to the supergraph | | |||
| `supergraph_query_variable` | Yes | | The name of a supergraph query variable | | |||
| `supergraph_request_header` | Yes | | The name of a supergraph request header | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this something that should be added on dev/main rather than next?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add it on dev
too
Signed-off-by: Benjamin <[email protected]>
Co-authored-by: Gary Pennington <[email protected]>
If you used the
experimental_when_header
feature previously like this for example:This feature no longer exists and can be replaced with another one included in custom telemetry. Here is how you would configure custom telemetry to achieve the same result: