Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add debugging client request overview #6507

Closed
wants to merge 11 commits into from

Conversation

Meschreiber
Copy link
Contributor

@Meschreiber Meschreiber commented Jan 3, 2025

Adds an overview page for debugging client requests

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Jan 3, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed
* graphos/routing/observability/index.mdx

Build ID: d7648ad16427d0cef13b020f

URL: https://www.apollographql.com/docs/deploy-preview/d7648ad16427d0cef13b020f

@Meschreiber Meschreiber marked this pull request as ready for review January 3, 2025 21:55
@Meschreiber Meschreiber requested a review from a team as a code owner January 3, 2025 21:55
@Meschreiber Meschreiber requested a review from smyrick January 3, 2025 21:55
@Meschreiber
Copy link
Contributor Author

Beyond some copyedits/restructuring this is largely the same as the original PR. LMK if it looks good to you @smyrick !

@smyrick
Copy link
Member

smyrick commented Jan 6, 2025

I responded to the comment. This look good to me. Not sure if we need a .changeset

@Meschreiber
Copy link
Contributor Author

Thanks @smyrick , since this targetsmain, I don't think I changeset would be picked up in any case.

@shorgi, when you take a look at this, could you confirm a docs change of this size (adding a whole new page) can skate by without a changeset? TIA

@shorgi
Copy link
Contributor

shorgi commented Jan 6, 2025

@shorgi, when you take a look at this, could you confirm a docs change of this size (adding a whole new page) can skate by without a changeset? TIA

We've been inconsistent on changesets for docs 😅. A new page though usually gets one.

Other issue is that resolving docs conflicts between main and dev aren't always smooth. @BrynCooke should we retarget this docs change to dev first?

@Meschreiber Meschreiber requested a review from shorgi January 6, 2025 19:59
@Meschreiber
Copy link
Contributor Author

Meschreiber commented Jan 6, 2025

Is there a way to publish this before then but include a changset for 1.60?

To clarify my earlier comment/question to Bryn, I'm wondering if we can first retarget these changes to dev then create another PR for main before the next router release

@BrynCooke
Copy link
Contributor

@Meschreiber You can target main. We're going to do something different once LTS is in place.

@Meschreiber Meschreiber requested a review from BrynCooke January 13, 2025 21:32
@Meschreiber
Copy link
Contributor Author

Closing in favor of #6563

@smyrick smyrick deleted the docs/add-debugging-client-requests branch January 22, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants