release: v1.60.0 #6647

abernix · 2025-01-24T15:48:56Z

Note
This particular PR must be true-merged to main.

This PR is only ready to review when it is marked as "Ready for Review". It represents the merge to the main branch of an upcoming release (version number in the title).
It will act as a staging branch until we are ready to finalize the release.
We may cut any number of alpha and release candidate (RC) versions off this branch prior to formalizing it.
This PR is primarily a merge commit, so reviewing every individual commit shown below is not necessary since those have been reviewed in their own PR. However, things important to review on this PR once it's marked "Ready for Review":
- Does this PR target the right branch? (usually, main)
- Are the appropriate version bumps and release note edits in the end of the commit list (or within the last few commits). In other words, "Did the 'release prep' PR actually land on this branch?"
- If those things look good, this PR is good to merge!

This mode will change the behaviour of the router for tracing in the following ways: * Spans are never dropped, instead they are converted to RecordOnly. * Spans that are sent to otlp and datadog exporters will always look like they have been sampled. * The `sampling.priority` attribute is populated on spans. * `psr` is populated in trace state. * `m` is populated in trace state.

…use rate based sampling from agent.

Co-authored-by: Edward Huang <[email protected]>

…port

We made some weird configuration previously to force particular behaviour which when looked at subsequently didn't make any sense. In particular the otlp tests should have had otlp propagation with the datadog propagator also enabled. Also added a chack for the subgraph service to ensure it is correctly sampled.

Co-authored-by: Coenen Benjamin <[email protected]>

…6538)

Co-authored-by: Maria Elisabeth Schreiber <[email protected]>

…6545)

Co-authored-by: Simon Sapin <[email protected]>

…6592) Co-authored-by: Bryn Cooke <[email protected]> Co-authored-by: bryn <[email protected]>

Co-authored-by: Maria Elisabeth Schreiber <[email protected]> Co-authored-by: Bryn Cooke <[email protected]>

…6634) (#6642)

Signed-off-by: Benjamin <[email protected]> Co-authored-by: Jesse Rosenberger <[email protected]>

…port #6637) (#6644)

…sh (backport #6622) (#6633) Co-authored-by: Ivan Goncharov <[email protected]> Co-authored-by: Renée Kooi <[email protected]>

svc-apollo-docs · 2025-01-24T15:49:00Z

⚠️ Docs preview not attached to branch

The preview was not built because the PR's base branch main is not in the list of sources.

An Apollo team member can comment one of the following commands to dictate which branch to attach the preview to:

!docs set-base-branch dev
!docs set-base-branch 1.x

Build ID: 750906b595fbd89fccc75bda

router-perf · 2025-01-24T15:49:27Z

CI performance tests

shorgi · 2025-01-27T06:46:56Z

.changesets/exp_bnjjj_fix_retry_metric.md

+### Remove experimental_retry ([PR #6338](https://github.com/apollographql/router/pull/6338))
+
+Remove `experimental_retry`. Looking at our analytics it looks like it's not used and it's not working properly. As it was an experimental feature in order to check if we needed this feature or not we decided to remove it.


Suggested change

### Remove experimental_retry ([PR #6338](https://github.com/apollographql/router/pull/6338))

Remove `experimental_retry`. Looking at our analytics it looks like it's not used and it's not working properly. As it was an experimental feature in order to check if we needed this feature or not we decided to remove it.

### Remove experimental_retry option ([PR #6338](https://github.com/apollographql/router/pull/6338))

The `experimental_retry` option has been removed due to its limited use and functionality during its experimental phase.

shorgi · 2025-01-27T06:48:34Z

.changesets/feat_bryn_named_runtime_channel.md

@@ -0,0 +1,13 @@
+### Improved BatchProcessor observability ([Issue #6558](https://github.com/apollographql/router/issues/6558))


Suggested change

### Improved BatchProcessor observability ([Issue #6558](https://github.com/apollographql/router/issues/6558))

### Improve BatchProcessor observability ([Issue #6558](https://github.com/apollographql/router/issues/6558))

shorgi · 2025-01-27T06:48:50Z

.changesets/fix_fix_invalid_error_path.md

@@ -0,0 +1,10 @@
+### Truncating Invalid Error Paths ([PR #6359](https://github.com/apollographql/router/pull/6359))


Suggested change

### Truncating Invalid Error Paths ([PR #6359](https://github.com/apollographql/router/pull/6359))

### Truncate invalid error paths ([PR #6359](https://github.com/apollographql/router/pull/6359))

shorgi · 2025-01-27T06:49:41Z

.changesets/fix_fix_invalid_error_path.md

+According to the [GraphQL Specification](https://spec.graphql.org/draft/#sel-GAPHRPHCAACCpC8-T) an error path must point to a **response field**:
+> If an error can be associated to a particular field in the GraphQL result, it must contain an entry with the key path that details the path of the response field which experienced the error.
+
+If a subgraph error includes a path that can't be matched to a response field, the router now truncates the path to the nearest valid field path. 


Suggested change

If a subgraph error includes a path that can't be matched to a response field, the router now truncates the path to the nearest valid field path.

The router now truncates the path to the nearest valid field path if a subgraph error includes a path that can't be matched to a response field,

shorgi · 2025-01-27T06:51:09Z

.changesets/fix_tninesling_demand_control_perf.md

@@ -0,0 +1,9 @@
+### Demand control lookup optimizations ([PR #6450](https://github.com/apollographql/router/pull/6450))


Suggested change

### Demand control lookup optimizations ([PR #6450](https://github.com/apollographql/router/pull/6450))

### Optimize demand control lookup ([PR #6450](https://github.com/apollographql/router/pull/6450))

shorgi · 2025-01-27T06:54:34Z

.changesets/fix_tninesling_demand_control_perf.md

+Demand Control can reduce router throughput due to the extra processing required for scoring. This change shifts more data to be computed at plugin initialization and consolidates lookup queries.
+
+- Cost directives for arguments are now stored in a map alongside those for field definitions
+- All precomputed directives are bundled into a struct for each field, along with that field's extended schema type. This reduces 5 individual lookups to a single lookup.
+- Response scoring was looking up each field's definition twice. This is now reduced to a single lookup.


Suggested change

Demand Control can reduce router throughput due to the extra processing required for scoring. This change shifts more data to be computed at plugin initialization and consolidates lookup queries.

- Cost directives for arguments are now stored in a map alongside those for field definitions

- All precomputed directives are bundled into a struct for each field, along with that field's extended schema type. This reduces 5 individual lookups to a single lookup.

- Response scoring was looking up each field's definition twice. This is now reduced to a single lookup.

The performance of demand control in the router has been optimized.

Previously, demand control could reduce router throughput due to its extra processing required for scoring.

This fix improves performance by shifting more data to be computed at plugin initialization and consolidating lookup queries:

- Cost directives for arguments are now stored in a map alongside those for field definitions

- All precomputed directives are bundled into a struct for each field, along with that field's extended schema type. This reduces 5 individual lookups to a single lookup.

- Response scoring was looking up each field's definition twice. This is now reduced to a single lookup.

shorgi · 2025-01-27T06:55:56Z

.changesets/maint_simon_unbridge.md

@@ -0,0 +1,11 @@
+### Remove the legacy query planner ([PR #6418](https://github.com/apollographql/router/pull/6418))
+
+The legacy query planner has been removed in this release. In the previous release, Router 1.58, it was already no longer used by default but it was still available through the `experimental_query_planner_mode`  configuration key. That key is now removed.


Suggested change

The legacy query planner has been removed in this release. In the previous release, Router 1.58, it was already no longer used by default but it was still available through the `experimental_query_planner_mode` configuration key. That key is now removed.

The legacy query planner has been removed in this release. In the previous release, router v1.58, it was no longer used by default but was still available through the `experimental_query_planner_mode` configuration key. That key is now removed.

lrlna · 2025-01-28T14:13:09Z

#6654 should land in 1.60.0 too, ideally

bryn and others added 30 commits October 3, 2024 20:10

Merge branch 'dev' into bryn/datadog-agent-support

001af54

Update docs

42247b7

Update docs

7ad4d02

Update docs

d8bf352

Update docs

110917c

Split the changelogs

562b7ac

Remove commented out code for auto enabling sampling

1776e59

Merge branch 'dev' into bryn/datadog-agent-support

5d1b0b4

Update docs to indicate that preview datadog agent sampling will NOT …

9b60c38

…use rate based sampling from agent.

Update docs/source/configuration/telemetry/exporters/tracing/datadog.mdx

16cd222

Co-authored-by: Edward Huang <[email protected]>

Update docs/source/configuration/telemetry/exporters/tracing/datadog.mdx

d7532ce

Co-authored-by: Edward Huang <[email protected]>

Apply suggestions from code review

c91a233

Co-authored-by: Edward Huang <[email protected]>

Apply suggestions from code review

98624c7

Co-authored-by: Edward Huang <[email protected]>

Merge branch 'dev' into bryn/datadog-agent-support

067eb56

Merge dev

43aa702

Merge remote-tracking branch 'public/dev' into bryn/datadog-agent-sup…

17e88fa

…port

Merge branch 'dev' into bryn/datadog-agent-support

8726737

Merge branch 'dev' into bryn/datadog-agent-support

8909929

Merge branch 'dev' into bryn/datadog-agent-support

1105d31

Merge branch 'dev' into bryn/datadog-agent-support

b8a8e20

Lint and test fixes

4490216

docs: remove redirects (#6419)

7e17f31

Remove the legacy query planner (#6418)

232f40d

Update Rust toolchain to 1.83.0 (#6444)

8171f3b

Co-authored-by: Coenen Benjamin <[email protected]>

docs: endpoint path param and wildcard (#6442)

5038401

docs: cmake and nodejs are no longer required (#6448)

efd912a

Truncating Invalid Error Paths (#6359)

4d5b6ad

chore(deps): Removed lazy_static (#6449)

e6b2fd2

nmoutschen and others added 24 commits January 16, 2025 12:10

chore: address PR review

5cf45f7

Merge branch 'dev' into nicolas/fleet-detector-fixes

241d5fd

fix(fleet_detector): use SizeHint for subgraph request when possible (#…

a2f7c27

…6538)

docs: add docker compose config example (#6554)

fab4214

Co-authored-by: Maria Elisabeth Schreiber <[email protected]>

Update to apollo-compiler 1.25.0 stable release (#6556)

817e878

chore: point developers to .with_metrics() in metrics assertions (#…

8e185b2

…6545)

Avoid re-computing implementers_map in QueryHashVisitor (#6570)

0382928

merge main into dev (#6578)

95501ca

Unpin AWS SDK dependencies (backport #6602) (#6603)

8592c64

Co-authored-by: Simon Sapin <[email protected]>

add page for deprecated query planner pools

e94b254

DOC-314 use DeprecatedFeature callout

1208b0c

use DeprecatedFeature callout for native Jaeger tracing

e44dfd8

Add batch exporter metrics and logging enhancements (backport #6558) (#…

77b84d5

…6592) Co-authored-by: Bryn Cooke <[email protected]> Co-authored-by: bryn <[email protected]>

docs: update Federation 1 support (backport #6574) (#6616)

da88379

Co-authored-by: Maria Elisabeth Schreiber <[email protected]> Co-authored-by: Bryn Cooke <[email protected]>

Merge branch '1.x' into eh/docs/1x-deprecated

60c6e2f

trigger CI

09bf154

trigger CI

39f9b03

trigger CI again

e4a2886

rerun CI

5c110fb

docs: deprecated query planner pool (#6617)

6b3cb1b

Fix increased memory usage in sysinfo since Router 1.59.0 (backport #…

71be9cc

…6634) (#6642)

document deprecated metrics (#6547)

802dfac

Signed-off-by: Benjamin <[email protected]> Co-authored-by: Jesse Rosenberger <[email protected]>

chore(tests): Apply nextest retries rules to known-flaky tests. (back…

9d753a1

…port #6637) (#6644)

Improve performance of query hashing by using a precomputed schema ha…

0baa02b

…sh (backport #6622) (#6633) Co-authored-by: Ivan Goncharov <[email protected]> Co-authored-by: Renée Kooi <[email protected]>

abernix added the release label Jan 24, 2025

prep release: v1.60.0-rc.0

7529374

shorgi reviewed Jan 27, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

release: v1.60.0 #6647

release: v1.60.0 #6647

abernix commented Jan 24, 2025

svc-apollo-docs commented Jan 24, 2025 •

edited

Loading

router-perf bot commented Jan 24, 2025

shorgi Jan 27, 2025

shorgi Jan 27, 2025

shorgi Jan 27, 2025

shorgi Jan 27, 2025

shorgi Jan 27, 2025

shorgi Jan 27, 2025

shorgi Jan 27, 2025

lrlna commented Jan 28, 2025

		### Remove experimental_retry ([PR #6338](https://github.com/apollographql/router/pull/6338))

		Remove `experimental_retry`. Looking at our analytics it looks like it's not used and it's not working properly. As it was an experimental feature in order to check if we needed this feature or not we decided to remove it.

		@@ -0,0 +1,13 @@
		### Improved BatchProcessor observability ([Issue #6558](https://github.com/apollographql/router/issues/6558))

	### Improved BatchProcessor observability ([Issue #6558](https://github.com/apollographql/router/issues/6558))
	### Improve BatchProcessor observability ([Issue #6558](https://github.com/apollographql/router/issues/6558))

		@@ -0,0 +1,10 @@
		### Truncating Invalid Error Paths ([PR #6359](https://github.com/apollographql/router/pull/6359))

	### Truncating Invalid Error Paths ([PR #6359](https://github.com/apollographql/router/pull/6359))
	### Truncate invalid error paths ([PR #6359](https://github.com/apollographql/router/pull/6359))

	If a subgraph error includes a path that can't be matched to a response field, the router now truncates the path to the nearest valid field path.
	The router now truncates the path to the nearest valid field path if a subgraph error includes a path that can't be matched to a response field,

		@@ -0,0 +1,9 @@
		### Demand control lookup optimizations ([PR #6450](https://github.com/apollographql/router/pull/6450))

	### Demand control lookup optimizations ([PR #6450](https://github.com/apollographql/router/pull/6450))
	### Optimize demand control lookup ([PR #6450](https://github.com/apollographql/router/pull/6450))

		@@ -0,0 +1,11 @@
		### Remove the legacy query planner ([PR #6418](https://github.com/apollographql/router/pull/6418))

		The legacy query planner has been removed in this release. In the previous release, Router 1.58, it was already no longer used by default but it was still available through the `experimental_query_planner_mode` configuration key. That key is now removed.

release: v1.60.0 #6647

Are you sure you want to change the base?

release: v1.60.0 #6647

Conversation

abernix commented Jan 24, 2025

svc-apollo-docs commented Jan 24, 2025 • edited Loading

⚠️ Docs preview not attached to branch

router-perf bot commented Jan 24, 2025

shorgi Jan 27, 2025

Choose a reason for hiding this comment

shorgi Jan 27, 2025

Choose a reason for hiding this comment

shorgi Jan 27, 2025

Choose a reason for hiding this comment

shorgi Jan 27, 2025

Choose a reason for hiding this comment

shorgi Jan 27, 2025

Choose a reason for hiding this comment

shorgi Jan 27, 2025

Choose a reason for hiding this comment

shorgi Jan 27, 2025

Choose a reason for hiding this comment

lrlna commented Jan 28, 2025

svc-apollo-docs commented Jan 24, 2025 •

edited

Loading