[DRAFT] improve generate fragment compression #6651
Conversation
dariuszkuc
changed the title
|
@dariuszkuc, please consider creating a changeset entry in |
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 8ba31fdea1d04a7b0006e0cc |
| let hash = self.hash_key(parent_type, selection_set); | ||
| *self.selection_counts.entry(hash).or_insert(0) += 1; |
There was a problem hiding this comment.
What happens if there is a hash collision here? We potentially generate fragments for things that might not need them? Is that all?
There was a problem hiding this comment.
After thinking about this some more, a hash collision here wouldn't cause too many problems, but mapping a hash to a named fragment would. Perhaps the inner type that you declare in the hash_key function should be used as the keys.
There was a problem hiding this comment.
We use this hash value as a key for minimized_fragments so if we have a collision we would end up with potentially generating invalid operation as our named fragments would be incorrect.
dariuszkuc
force-pushed
the
gen_fragment_v2
branch
from
a11d4e7 to
fdd1b47
Compare
dariuszkuc
force-pushed
the
gen_fragment_v2
branch
from
208f22d to
ceac413
Compare
Description here
Fixes #issue_number
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩