Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes use of mobile preview plugin for apos build #4823

Merged
merged 2 commits into from
Dec 18, 2024
Merged

removes use of mobile preview plugin for apos build #4823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3740684
removes use of mobile preview plugin for apos build
ValJed Dec 18, 2024
376a387
adds changelog
ValJed Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
* Fixes broken widget preview URL when the image is overridden (module improve) and external build module is registered.
* Inject dynamic custom bundle CSS when using external build module with no CSS entry point.
* Range field now correctly takes 0 into account.
* Apos style does not go through `postcss-viewport-to-container-toggle` plugin anymore to avoid UI bugs.

### Adds

Expand Down
9 changes: 0 additions & 9 deletions modules/@apostrophecms/asset/lib/webpack/apos/webpack.scss.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,5 @@
const postcssViewportToContainerToggle = require('postcss-viewport-to-container-toggle');

module.exports = (options, apos) => {
const postcssPlugins = [
...apos.asset.options.breakpointPreviewMode?.enable === true ? [
postcssViewportToContainerToggle({
modifierAttr: 'data-breakpoint-preview-mode',
debug: apos.asset.options.breakpointPreviewMode?.debug === true,
transform: apos.asset.options.breakpointPreviewMode?.transform || null
})
] : [],
'autoprefixer',
{}
];
Expand Down
Loading