Initial module implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iujames
approved these changes
May 3, 2024
| apply plugin: 'maven-publish' | ||
|
|
||
| group = 'expo.modules.appcuesexpoconfig' | ||
| version = '0.1.0' |
There was a problem hiding this comment.
curious what this version is used for and whether it needs to stay in sync with the overall package version on release... will continue reading
There was a problem hiding this comment.
I'm not sure. I think it's entirely internal (same idea as AppcuesExpoConfig.podspec), so I don't think it matters, but it probably should match other versions, just so it's not confusing?
mmaatttt
force-pushed
the
feature/initial-module
branch
from
ff0c3db to
cd10de8
Compare
mmaatttt
force-pushed
the
feature/initial-module
branch
from
cd10de8 to
567b929
Compare
mmaatttt
commented
May 8, 2024
Comment on lines
+73
to
+80
| // https://github.com/apache/cordova-node-xcode/issues/121 | ||
| // addTargetDependency misses some dependency links if | ||
| // PBXTargetDependency or PBXContainerItemProxy are not present. | ||
| const projObjects = xcodeProject.hash.project.objects; | ||
| projObjects['PBXTargetDependency'] = | ||
| projObjects['PBXTargetDependency'] || {}; | ||
| projObjects['PBXContainerItemProxy'] = | ||
| projObjects['PBXContainerItemProxy'] || {}; |
There was a problem hiding this comment.
Added this block after encountering issues when testing today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expo Overview
The Expo Modules API allows you to "write custom native code to tap into native platform APIs". There are three main APIs:
Unrelated (but can be packaged together), there are Expo config plugins that extend the app config and allow for mod(ifications)s of parts the Expo build process (eg the Xcode project, plists, gradle files).
There's a helpful Expo tutorial, Create a module with a config plugin that while not exactly what we need, show how to combine the concepts.
Implementation Overview
This PR includes a combination of the above:
plugin/*Config plugin that copies the notification services extension to the generated project, adds the extension to the Xcode project, and updates the Podfile to make the new target depend on theAppcuesNotificationExtensionpod.ios/*iOS AppDelegate subscriber to callAppcues.enableAutomaticPushConfig(). TheAppcuesExpoConfig.podspecadds the dependency on theAppcuespod. The subscriber is registered inexpo-module.config.json.android/*This is where an Android lifecycle listener code would go, but we don't actually need that functionality. What we do need here is just need thebuild.gradleto ensure the Appcues dependency is set, and then the manifest to handle the intent.Notes
android/build.gradleplugin/src/withIosAppcuesRichPush.tswhere we add the target info to the project Podfileandroid/src/main/AndroidManifest.xml.@appcues/react-native. That package functions as a sibling. Obviously you'd want to use them together to do anything productive, but they are independent.