Add ArgumentParser #16
Conversation
|
Thank you for adding this! It's another great step in the right direction. This seems like a breaking change, seeing as the way we pass in languages is changing. Are there any other potential breaking changes that you may want to make in the short term? |
|
Nice to hear that! I'm currently working on getting the string catalog checks to be executed in parallel, which will force us to set the minimum required macOS version to 10.15 (aka macOS Catalina). I'm not sure if we should consider this a breaking change, but probably yes. |
…tCore initializer's parameters
pereBohigas
force-pushed
the
feature/add_argument_parser
branch
from
92112ce to
38c1960
Compare
Ok, sounds good! I doubt anybody is using the package on anything less than macOS 10.15 at this stage. Small FYI - I'll be on vacation for roughly the next 3 weeks! I'll have my laptop, but I'll be slow to respond. |
|
Just going to test this against my apps before merging. |
pereBohigas
force-pushed
the
feature/add_argument_parser
branch
from
38c1960 to
a86446f
Compare
Don't worry, there's nothing urgent that can't wait. Enjoy your 🌴! |
|
I have just corrected the command name in the help message, which I had not noticed until now
|
There was a problem hiding this comment.
Apologies for the delay in reviewing this! I've just tested against one of my apps and it looks good to me.
Given the breaking changes, I'm thinking it might be a good idea to merge this in to a v1 branch, where we can collect any other changes over the next few weeks before we update main and do an official release. What do you think?
I'm glad to have you back! It's fine for me. Would you like to include #17 also into this branch? |
yes! |
* Add ArgumentParser (#16) * Add ArgumentParser dependency * Rename SwiftPolyglotCore struct * Add RuntimeError * Rename SwiftPolyglot struct, add ParsableCommand adoption and add RuntimeError usage * Parse arguments and flag using ArgumentParser and adjust SwiftPolyglotCore initializer's parameters * Update README * Rename property * Format * Fix command name in help's message * Add Concurrency (#17) * Set minimum macOS version to version 10.15 (Catalina) * Add MissingTranslation struct * Add concurrency to core functionality * Adopt AsyncParsableCommand protocol to provide an asynchronous entry point * Add XCTest extension for testing async throwing expressions * Add concurrency to tests * Fix SwiftFormat issues (#19) * Remove trailing commas * Fix indentation * Move inline try to start of expression * Remove trailing white spaces * Use opaque generic parameters instead of generic parameters with constraints * Replace consecutive blank lines with a single blank line * Disable hoistAwait (#20) * Fix swiftformat (#21) * Improve assertions on async throwing expressions (#22) * Add Equatable adoption for custom error * Improve custom method for asserting on asynchronous expressions which should run successfully without throwing an error * Improve custom method for asserting on asynchronous expressions which should throw an error * Reenable hoistAwait SwiftFormat rule --------- Co-authored-by: Pere Bohigas <[email protected]>
Aloha!!
The Swift's Argument Parser is here being added to the project. Now, useful error messages and a nice help are being shown to the user.
Following the best practices for command line tools APIs, the languages to be checked are now passed as a list of arguments separated by spaces (e.g.
swiftpolyglot en es).Cheers!!