Improve assertions on async throwing expressions #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… should run successfully without throwing an error
Merged
pereBohigas
force-pushed
the
feature/improve_assertions_on_async_throwing_expressions
branch
from
b0a5258 to
eae1d3f
Compare
pereBohigas
force-pushed
the
feature/improve_assertions_on_async_throwing_expressions
branch
from
eae1d3f to
d58b2eb
Compare
roddymunro
approved these changes
Jun 4, 2024
roddymunro
added a commit
that referenced
this pull request
Jun 12, 2024
* Add ArgumentParser (#16) * Add ArgumentParser dependency * Rename SwiftPolyglotCore struct * Add RuntimeError * Rename SwiftPolyglot struct, add ParsableCommand adoption and add RuntimeError usage * Parse arguments and flag using ArgumentParser and adjust SwiftPolyglotCore initializer's parameters * Update README * Rename property * Format * Fix command name in help's message * Add Concurrency (#17) * Set minimum macOS version to version 10.15 (Catalina) * Add MissingTranslation struct * Add concurrency to core functionality * Adopt AsyncParsableCommand protocol to provide an asynchronous entry point * Add XCTest extension for testing async throwing expressions * Add concurrency to tests * Fix SwiftFormat issues (#19) * Remove trailing commas * Fix indentation * Move inline try to start of expression * Remove trailing white spaces * Use opaque generic parameters instead of generic parameters with constraints * Replace consecutive blank lines with a single blank line * Disable hoistAwait (#20) * Fix swiftformat (#21) * Improve assertions on async throwing expressions (#22) * Add Equatable adoption for custom error * Improve custom method for asserting on asynchronous expressions which should run successfully without throwing an error * Improve custom method for asserting on asynchronous expressions which should throw an error * Reenable hoistAwait SwiftFormat rule --------- Co-authored-by: Pere Bohigas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Here the custom methods on XCTest for asserting on async throwing expressions are being modified and the usage of the
@autoclosureattribute (which seems not to be suitable for wrapping asynchronous expressions) is being removed. Some other minor improvements are also being introduced.PD: The disablement of the
hoistAwaitSwiftFormat rule is no longer required, and therefore the rule is being enabled again.Cheers!