-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for Pathways proxy #690
Open
jesus-orozco
wants to merge
13
commits into
apple:main
Choose a base branch
from
jesus-orozco:feature/jax_pathways
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28
−4
Open
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
582329a
Adding support for Pathways proxy
jesus-orozco 8d3c643
Update pathways-utils dependency and fix formatting
jesus-orozco 0e61b76
Move pathways package to its own dependency tree and pin it to a spec…
jesus-orozco 4260c38
Relocate pathwaysutils import
jesus-orozco f02d345
Merge branch 'main' into feature/jax_pathways
jesus-orozco 6c3c083
Merge branch 'apple:main' into feature/jax_pathways
jesus-orozco ac6bcd2
Update pathwaysutils source to pypi
jesus-orozco 05f311d
Merge branch 'apple:main' into feature/jax_pathways
jesus-orozco 1797c52
Merge branch 'main' into feature/jax_pathways
jesus-orozco 4868815
Refactor pathways config flag
jesus-orozco b51e67e
Update axlearn/cloud/gcp/job.py
jesus-orozco 6537274
Update job.py with dynamic module imports
jesus-orozco 7dbb1b9
Update job.py - remove pathways from dynamic import error message
jesus-orozco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,7 +53,8 @@ def setup( | |
if initialization_timeout is not None: | ||
init_kwargs["initialization_timeout"] = initialization_timeout | ||
|
||
if jax_backend == "tpu": | ||
# TPU resources orchestrated by Pathways use 'proxy' as the JAX backend | ||
if jax_backend in ("tpu", "proxy"): | ||
jesus-orozco marked this conversation as resolved.
Show resolved
Hide resolved
|
||
if not ( | ||
distributed_coordinator is None and num_processes is None and process_id is None | ||
): | ||
|
@@ -115,5 +116,6 @@ def setup( | |
f"({initialization_timeout} seconds)." | ||
) | ||
else: | ||
jax.distributed.initialize(**init_kwargs) | ||
_jax_distributed_initialized = True | ||
if jax_backend != "proxy": | ||
jax.distributed.initialize(**init_kwargs) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So using pathways does not require There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Rebased and added comment for pathways |
||
_jax_distributed_initialized = True |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of a boolean flag, could we define a list flag specifying the additional modules to import, potentially including "pathwaysutils"?
See https://github.com/apple/axlearn/blob/main/docs/ml_api_style.md#avoid-booleans-in-apis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this makes sense. Refactored the flag and using dynamic import instead.