ThreadReturnPromiseStream: do ref-counting safely #12093

vishesh · 2025-04-17T20:02:39Z

The original ThreadReturnPromiseStream didn't handle reference counting
in a thread-safe way. This led to subtle and hard-to-debug race conditions, especially since Future
and Promise often live on different threads in this use case.

This patch introduces a new implementation of ThreadReturnPromiseStream that uses an atomics backed
spinlock to safely manage reference counts. As a result, the Flow compiler also needs to support a
new type: ThreadFutureStream, in addition to the existing FutureStream.

The underlying NotifiedQueue now has a parallel implementation called ThreadNotifiedQueue to
make this possible. The higher-level thread-safe promise and promise counterpart are built on top of
that.

The new ThreadFutureStream is compatible with both Flow and C++ coroutines. The original
non-threaded Flow primitives remain untouched and free from the overhead of atomics.

Joshua:

20250417-000356-vishesh-16ce18efeab40158 compressed=True data_size=41124943 duration=5436274 ended=99998 fail=1 fail_fast=10 max_runs=100000 pass=99997 priority=100 remaining=0:00:00 runtime=1:00:47 sanity=False started=100000 submitted=20250417-000356 timeout=5400 username=vishesh

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

The PR has a description, explaining both the problem and the solution.
The description mentions which forms of testing were done and the testing seems reasonable.
Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

foundationdb-ci · 2025-04-17T20:07:46Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 432e146
Duration 0:04:55
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-17T20:07:48Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 432e146
Duration 0:05:00
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-17T20:07:49Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 432e146
Duration 0:04:59
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-17T20:07:51Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 432e146
Duration 0:04:59
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2025-04-17T20:07:53Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 432e146
Duration 0:05:03
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-17T20:14:11Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 432e146
Duration 0:11:18
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-17T20:15:36Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 432e146
Duration 0:12:46
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-17T20:28:45Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 278fd53
Duration 0:04:51
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-17T20:28:53Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 278fd53
Duration 0:04:58
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-17T20:28:57Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 278fd53
Duration 0:05:01
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-17T20:29:07Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 278fd53
Duration 0:05:12
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2025-04-17T20:29:09Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 278fd53
Duration 0:05:14
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-17T20:34:29Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 278fd53
Duration 0:10:34
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-17T20:35:58Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 278fd53
Duration 0:12:04
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

flow/include/flow/FlowThread.h

flow/actorcompiler/ActorCompiler.cs

flow/include/flow/FlowThread.h

fdbrpc/FlowTests.actor.cpp

flow/include/flow/CoroutinesImpl.h

flow/include/flow/FlowThread.h

foundationdb-ci · 2025-04-18T19:28:37Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: e04b606
Duration 0:04:48
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-18T19:28:43Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: e04b606
Duration 0:04:53
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-18T19:28:48Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: e04b606
Duration 0:05:03
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-18T19:28:50Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: e04b606
Duration 0:05:02
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2025-04-18T19:29:06Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: e04b606
Duration 0:05:16
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-18T19:35:52Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: e04b606
Duration 0:12:05
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

saintstack · 2025-04-21T16:31:15Z

We also should run the kube test that originally was crashing and resulting in reverting the previous patch.

I ran our big k8s test (bulk load a production-size dataset into a cluster -- twice) and it ran fine... No hanging servers as we were seeing with #12003 (reverted by #12050)

foundationdb-ci · 2025-04-21T21:11:35Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: e5e52f0
Duration 0:06:07
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-21T21:11:45Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: e5e52f0
Duration 0:06:19
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-21T21:15:35Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: e5e52f0
Duration 0:10:09
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-21T21:30:23Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 80f75bc
Duration 0:06:00
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-21T21:35:54Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 80f75bc
Duration 0:11:32
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-22T20:06:21Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: dffe0cf
Duration 0:38:05
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2025-04-22T20:06:31Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: dffe0cf
Duration 0:38:18
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-22T20:09:03Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: de4292d
Duration 1:07:43
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-22T20:16:03Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: dffe0cf
Duration 0:47:45
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-22T20:19:26Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: dffe0cf
Duration 0:51:12
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-22T20:29:55Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 4b49a2d
Duration 0:39:02
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2025-04-22T20:31:25Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: dffe0cf
Duration 1:03:07
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-22T20:40:22Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 4b49a2d
Duration 0:49:34
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-22T20:42:47Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 4b49a2d
Duration 0:51:57
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-22T20:49:36Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 4b49a2d
Duration 0:58:45
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-22T21:01:45Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 960c0a6
Duration 0:06:32
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-22T21:02:24Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 960c0a6
Duration 0:07:12
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-22T21:21:57Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 960c0a6
Duration 0:26:45
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-22T21:33:03Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 960c0a6
Duration 0:37:53
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2025-04-22T21:45:23Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 960c0a6
Duration 0:50:14
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-22T21:51:04Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 960c0a6
Duration 0:55:51
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-22T21:54:31Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 960c0a6
Duration 0:59:22
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-22T23:06:19Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 1c66155
Duration 0:12:03
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-22T23:20:18Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 1c66155
Duration 0:26:03
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-22T23:32:24Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 1c66155
Duration 0:38:06
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-22T23:33:20Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 1c66155
Duration 0:39:00
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2025-04-22T23:42:37Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 1c66155
Duration 0:48:18
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-22T23:58:38Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 1c66155
Duration 1:04:23
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-04-23T00:00:59Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 1c66155
Duration 1:06:45
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

jzhou77

LGTM

vishesh · 2025-04-25T23:45:54Z

merging. 1 failure in Joshua run is unrelated.

20250425-211620-vishesh-3506c23824abf1a3 compressed=True data_size=41138684 duration=5764732 ended=100000 fail=1 fail_fast=10 max_runs=100000 pass=99999 priority=100 remaining=0 runtime=0:55:05 sanity=False started=100000 stopped=20250425-221125 submitted=20250425-211620 timeout=5400 username=vishesh

jzhou77 reviewed Apr 17, 2025

View reviewed changes

flow/include/flow/FlowThread.h Show resolved Hide resolved

flow/actorcompiler/ActorCompiler.cs Show resolved Hide resolved

saintstack reviewed Apr 17, 2025

View reviewed changes

flow/include/flow/FlowThread.h Show resolved Hide resolved

fdbrpc/FlowTests.actor.cpp Show resolved Hide resolved

flow/include/flow/CoroutinesImpl.h Show resolved Hide resolved

flow/include/flow/FlowThread.h Outdated Show resolved Hide resolved

vishesh force-pushed the flow-thread-promise branch from 278fd53 to e04b606 Compare April 18, 2025 19:23

vishesh force-pushed the flow-thread-promise branch from e5e52f0 to 80f75bc Compare April 21, 2025 21:24

vishesh force-pushed the flow-thread-promise branch from 4b49a2d to 960c0a6 Compare April 22, 2025 20:55

fix pr build

1c66155

vishesh force-pushed the flow-thread-promise branch from 960c0a6 to 1c66155 Compare April 22, 2025 22:54

jzhou77 approved these changes Apr 23, 2025

View reviewed changes

vishesh merged commit 04a57c5 into apple:main Apr 25, 2025
5 of 7 checks passed

ThreadReturnPromiseStream: do ref-counting safely #12093

ThreadReturnPromiseStream: do ref-counting safely #12093

Conversation

vishesh commented Apr 17, 2025

Code-Reviewer Section

For Release-Branches

foundationdb-ci commented Apr 17, 2025

Result of foundationdb-pr-clang-ide on Linux CentOS 7

foundationdb-ci commented Apr 17, 2025

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented Apr 17, 2025

Result of foundationdb-pr-clang-arm on Linux CentOS 7

foundationdb-ci commented Apr 17, 2025

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented Apr 17, 2025

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented Apr 17, 2025

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented Apr 17, 2025

Result of foundationdb-pr-macos on macOS Ventura 13.x

foundationdb-ci commented Apr 17, 2025

Result of foundationdb-pr-clang-arm on Linux CentOS 7

foundationdb-ci commented Apr 17, 2025

Result of foundationdb-pr-clang-ide on Linux CentOS 7

foundationdb-ci commented Apr 17, 2025

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented Apr 17, 2025

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented Apr 17, 2025

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented Apr 17, 2025

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented Apr 17, 2025

Result of foundationdb-pr-macos on macOS Ventura 13.x

foundationdb-ci commented Apr 18, 2025

Result of foundationdb-pr-clang-ide on Linux CentOS 7

foundationdb-ci commented Apr 18, 2025

Result of foundationdb-pr-clang-arm on Linux CentOS 7

foundationdb-ci commented Apr 18, 2025

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented Apr 18, 2025

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented Apr 18, 2025

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented Apr 18, 2025

Result of foundationdb-pr-macos on macOS Ventura 13.x

saintstack commented Apr 21, 2025

foundationdb-ci commented Apr 21, 2025

Result of foundationdb-pr-clang-ide on Linux CentOS 7

foundationdb-ci commented Apr 21, 2025

Result of foundationdb-pr-macos on macOS Ventura 13.x

foundationdb-ci commented Apr 21, 2025

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented Apr 21, 2025

Result of foundationdb-pr-clang-ide on Linux CentOS 7

foundationdb-ci commented Apr 21, 2025

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented Apr 22, 2025

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented Apr 22, 2025

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented Apr 22, 2025

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented Apr 22, 2025

Result of foundationdb-pr-clang-arm on Linux CentOS 7

foundationdb-ci commented Apr 22, 2025

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented Apr 22, 2025

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented Apr 22, 2025

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented Apr 22, 2025

Result of foundationdb-pr-clang-arm on Linux CentOS 7

foundationdb-ci commented Apr 22, 2025

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented Apr 22, 2025

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented Apr 22, 2025

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented Apr 22, 2025