Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http-netty: Add support for GC based message leak detection #3162

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

http-netty: Add support for GC based message leak detection #3162

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
72d4151
Wip of leak detection working as intended
bryce-anderson Jan 9, 2025
47d1fcf
Cleanup and weak ref based removal
bryce-anderson Jan 10, 2025
ed72a8c
cleanup
bryce-anderson Jan 14, 2025
65d143b
Filter refactoring
bryce-anderson Jan 14, 2025
df3b01f
Whitespace
bryce-anderson Jan 14, 2025
9711aa9
Merge remote-tracking branch 'origin/main' into bl_anderson/aggressiv…
bryce-anderson Jan 14, 2025
51fa178
Some cleanup
bryce-anderson Jan 14, 2025
aa9763d
Even more cleanup
bryce-anderson Jan 14, 2025
6ffa2a1
Fix copyright
bryce-anderson Jan 15, 2025
86a2935
A bit of cleanup, but there is work to do
bryce-anderson Jan 17, 2025
1f02eac
Revert ref
bryce-anderson Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Some cleanup
  • Loading branch information
@bryce-anderson
bryce-anderson committed Jan 14, 2025
commit 51fa178093e5501b636014710be7260cb1db4e52
7 changes: 3 additions & 4 deletions servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/WatchdogLeakDetectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
*/
package io.servicetalk.http.netty;

import io.netty.buffer.ByteBufUtil;
import io.servicetalk.buffer.api.Buffer;
import io.servicetalk.buffer.netty.BufferAllocators;
import io.servicetalk.concurrent.PublisherSource;
Expand All @@ -29,13 +28,14 @@
import io.servicetalk.http.api.HttpServerContext;
import io.servicetalk.http.api.StreamingHttpClient;
import io.servicetalk.http.api.StreamingHttpResponse;

import io.netty.buffer.ByteBufUtil;
import org.junit.jupiter.api.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import javax.annotation.Nullable;

import java.net.InetSocketAddress;
import javax.annotation.Nullable;

import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.equalTo;
Expand Down Expand Up @@ -111,7 +111,6 @@ private static Buffer payload() {
return BufferAllocators.DEFAULT_ALLOCATOR.fromAscii("Hello, world!");
}


private static void abandon(Publisher<?> messageBody) {
SourceAdapters.toSource(messageBody).subscribe(new PublisherSource.Subscriber<Object>() {
@Override
Expand Down