Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concurrent-api: Make the CapturedContext API's public #3203

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bryce-anderson
Copy link
Contributor

Motivation:

The CapturedContext API's seem to do what we want them to but they're not yet public.

Modifications:

Make them public.

Motivation:

The CapturedContext API's seem to do what we want them to but
they're not yet public.

Modifications:

Make them public.
@bryce-anderson bryce-anderson changed the title concurrent-api: Makethe CapturedContext API's public concurrent-api: Make the CapturedContext API's public Mar 7, 2025
Copy link
Contributor

@mgodave mgodave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are happy with this API and /thinking/ about it longer isn't really going to land us anywhere significantly different.

@idelpivnitskiy
Copy link
Member

PR looks great. We discussed it offline and agreed to merge it right after the next release to give us one more cycle for testing. Marking it as a draft for now.

@idelpivnitskiy idelpivnitskiy marked this pull request as draft March 14, 2025 17:20
@bryce-anderson bryce-anderson marked this pull request as ready for review March 21, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants