loadbalancer: add some logging to RandomSubsetter #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: It could be helpful for people to know what happened during subsetting. Modifications: Add some logging to RandomSubsetter. This required some extra changes so that we could pass in the load balancer description so it's easier to know which subsetter we're actually talking about. Result: Better observability.
| @@ -71,7 +72,7 @@ private static Set<PrioritizedHost> subsetSet(int randomSubsetSize, List<Priorit | |||
| } | |||
|
|
|||
| private static List<PrioritizedHost> subset(int randomSubsetSize, List<PrioritizedHost> hosts) { | |||
| return new RandomSubsetter(randomSubsetSize).subset(hosts); | |||
| return new RandomSubsetter.RandomSubsetterFactory(randomSubsetSize).build("").subset(hosts); | |||
There was a problem hiding this comment.
Is it a factory or a builder? looks a bit confusing to see a build method on a factory.
Consider either renaming to builder or use "create"/"newSubsetter"/etc. method
There was a problem hiding this comment.
Good point. Let's go with newSubsetter.
| @@ -56,6 +68,10 @@ public <T extends PrioritizedHost> List<T> subset(List<T> nextHosts) { | |||
| } | |||
| } | |||
| } | |||
| if (LOGGER.isDebugEnabled()) { | |||
| LOGGER.debug("{}: Using {} hosts out of a total {}. ({} considered unhealthy)", lbDescription, | |||
| result.size(), allHosts.size(), result.size() - allHosts.size()); | |||
There was a problem hiding this comment.
Should we log what hosts were picked? Might be worth at debug level
| public <T extends PrioritizedHost> List<T> subset(List<T> allHosts) { | ||
| if (allHosts.size() <= randomSubsetSize) { | ||
| if (LOGGER.isDebugEnabled()) { | ||
| LOGGER.debug("{}: Host set size of {} is less than designated subset ({})", |
There was a problem hiding this comment.
Should we say what action was made based on that criteria? For example:
"{}: Host set size of {} is less than designated subset ({})", returning all hosts as-is
idelpivnitskiy
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It could be helpful for people to know what happened during subsetting.
Modifications:
Add some logging to RandomSubsetter. This required some extra changes so that we could pass in the load balancer description so it's easier to know which subsetter we're actually talking about.
Result:
Better observability.