Add singleton to indicate which shell is requesting completion candidates #680
+702
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgoldberg
force-pushed
the
672-completion-per-shell
branch
2 times, most recently
from
bfe66ae
to
21ead87
Compare
…ates A CompletionShell singleton named CompletionShell.requesting has been created that indicates which shell is requesting completion candidates. The singleton is populated when a completion script is generated, so functions used to generate arguments for CompletionKind creation functions can return completion candidate syntax / shell commands tailored for that shell. For the custom(:) CompletionKind creation function, the singleton is populated at runtime (when a completion script requests completions from the Swift app after a user types tab while composing a command line to call the app). The requesting shell is communicated to the Swift app via an environment variable named SAP_SHELL, which is exported by each of the generated completion scripts. Resolve apple#672 Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg
force-pushed
the
672-completion-per-shell
branch
from
21ead87
to
30e0f78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add singleton to indicate which shell is requesting completion candidates.
A
CompletionShellsingleton namedCompletionShell.requestinghas been created that indicates which shell is requesting completion candidates.The singleton is populated when a completion script is generated, so functions used to generate arguments for
CompletionKindcreation functions can read the singleton to be able to return completion candidates / shell commands tailored for the requesting shell.For the
custom(:)CompletionKindcreation function, the singleton is populated at runtime (when a completion script requests completions from the Swift app after a user types tab while composing a command line to call the app).The requesting shell is communicated to the Swift app via an environment variable named
SAP_SHELL, which is exported by each of the generated completion scripts.Resolve #672
Checklist