Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Use @retroactive in test conformances #371

Open
wants to merge 1 commit into
base: release/1.1
Choose a base branch
from

Conversation

lorentey
Copy link
Member

The swift-collections test suite includes some test protocols to validate that dictionary- and set-like types provide the API surfaces that’s expected of their kind. These are being conformed to in the test targets, triggering new warnings on retroactive conformances.

Use @retroactive to silence such warnings.

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

@lorentey
Copy link
Member Author

(I expect this will fail on Swift 5.7, possibly 5.8.)

@lorentey lorentey added this to the 1.1.1 milestone Apr 23, 2024
@lorentey
Copy link
Member Author

@swift-ci test

1 similar comment
@lorentey
Copy link
Member Author

@swift-ci test

The swift-collections test suite includes some test protocols to validate that dictionary- and set-like types provide the API surfaces that’s expected of their kind. These are being conformed to in the test targets, triggering new warnings on retroactive conformances.

Use `@retroactive` to silence such warnings.
@lorentey lorentey force-pushed the admit-retroactive-conformances branch from 3c9a7ba to f46333d Compare May 29, 2024 20:25
@lorentey
Copy link
Member Author

Hm; dropping this from the 1.1.1 milestone, as we do not have a shipping Swift compiler that understands @retroactive yet.

@lorentey lorentey removed this from the 1.1.1 milestone May 29, 2024
@lorentey lorentey added this to the 1.1.4 milestone Sep 24, 2024
@lorentey
Copy link
Member Author

Swift 6 is out now; if @retroactive made it into the release, then we can apply this fix now. Rescheduling to 1.1.4.

@lorentey lorentey modified the milestones: 1.1.4, 1.2.0 Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant