Android support #70
Android support #70
Conversation
There was a problem hiding this comment.
Thanks for opening this PR. At this point we can't take this PR until we get an officially published Android toolchain from swift.org. See swiftlang/github-workflows#106 (comment).
My hope is the Android WG together with the Platforms Steering Group can sort this out soon and we can add Android CI to all of our repos.
There was a problem hiding this comment.
Given @FranzBusch's message, I'll mark this as blocked for now. But thanks for taking the time to make the updates!
|
How about if I remove the CI but leave in the fix for Lock.swift? It's just a one-line conditional import that will prevent build failures for dependent packages that are trying to build for Android. Similar PRs have been accepted by numerous other apple repos… |
Yes please. Happy to take patches that fix Android!. |
|
I've removed the CI. |
|
@FranzBusch can you update your review? I'd prefer not to have to admin merge here :) |
Motivation
This package wasn't building on Android, causing various dependent packages to also fail to build.
Modifications
Add the necessary
import(Android)to successfully build.Result
The package can now be built for Android.
Test Plan
Added CI to build and run against an Android emulator using swift-android-action.