-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
installer #366
base: master
Are you sure you want to change the base?
installer #366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution Omid!
This looks good, however some text requires copy-editing. I've made suggestions whenever I could. Please let us know if you need help on this (e.g. on Discord).
A few additional remarks:
-
Did you use any tool in particular to generate this installer? Could you tell us a bit more about the process you followed, and especially the process that should be followed to keep it up-to-date?
-
Please remove the
*.msi
file from the pull request. Instead those should eventually find their way to our Releases page: https://github.com/appleseedhq/appleseed-max/releases -
I think the
icon.ico
file can be improved, it's somewhat blurry at the moment and it's not centered in the image. You can find official appleseed logos here:
https://github.com/appleseedhq/appleseed/tree/master/resources/logoFor instance, this file might be a good starting point for a higher quality icon:
https://github.com/appleseedhq/appleseed/blob/master/resources/logo/appleseed-seeds-512.png -
I would suggest to rename the folder from
appleseed-Installer
to simplyinstaller
(all lower case).
Appleseed 3dsmax plugin Installer base on Wix toolset