Improvements to MacOS packaging

[markreidvfx]

• ported over changes from appleseed-maya packaging
• package script optionally builds a Application
• package script builds dmg file instead of zip

[dictoon]

Awesome!

I'm nitpicking but I wonder if the appleseed logo shouldn't be shown in perspective on the drive icon?

[dictoon]

Some more comments.

[dictoon]

So the story here is that on macOS we have to rename appleseed.studio to appleseed-studio in order to allow double-clicking on the file in the Finder to start the app. Is this workaround still necessary?

[markreidvfx]

Ah I see, I was wondering why. I was thinking of just moving the executable too. I was surprised that mac didn't complain about the main executable being a symlink.

[dictoon]

So, we keep the workaround?

[dictoon]

This is a significant change, did you check that it still works?

[markreidvfx]

I'll double check if this is correct, I know why these self references happen so I'll update the comments too.

[dictoon]

Did you mean to fix/update the code and comment here? As far as I can tell, the situation hasn't changed since I've made the comment that this was a significant change.

[markreidvfx]

@dictoon how is this for the drive icon instead? I rendered it with appleseed.

[dictoon]

I rendered it with appleseed.

Ah, lovely touch :)

The logo is a bit washed out, maybe that can be fixed in post to approach the correct color?

[markreidvfx]

The logo is a bit washed out

You are correct the texture is getting double srgb'd. Enabling CMS on the asTexure fixes it.

also keymixed in the albedo for the logo

[dictoon]

Lovely!

[dictoon]

Testing your script, I got the following error:

  Mac-specific: Adding dependencies to staging directory...
Traceback (most recent call last):
  File "./appleseed.package.py", line 1244, in <module>
    main()
  File "./appleseed.package.py", line 1238, in main
    package_builder.build_package()
  File "./appleseed.package.py", line 393, in build_package
    self.orchestrate()
  File "./appleseed.package.py", line 411, in orchestrate
    self.postprocess_stage()
  File "./appleseed.package.py", line 707, in postprocess_stage
    self.__add_dependencies_to_stage()
  File "./appleseed.package.py", line 734, in __add_dependencies_to_stage
    self.add_unix_dependencies_to_stage(self.get_paths_to_binaries())
  File "./appleseed.package.py", line 504, in add_unix_dependencies_to_stage
    libs = self.get_dependencies_for_file(path)
  File "./appleseed.package.py", line 993, in get_dependencies_for_file
    fatal("Unable to Resolve lib {}", lib)
TypeError: fatal() takes exactly 1 argument (2 given)

[markreidvfx]

Guess there needs to be a .format(lib) there instead

[dictoon]

Hi Mark,

I'd love to get this PR merged. Would you mind updating it? I'll also do some more tests in the coming days.

Thanks!

[markreidvfx]

Sorry for the delay, a couple other projects came up. I'll try and get this finished up when I'm back from holidays in the new year!

[dictoon]

Looks good, thank you!

[dictoon]

Upon closer inspection, the self-references thing when iterating over dependencies is still pending.

[oktomus]

Hi @markreidvfx, thanks your contribution :) Do you still plan on working on that PR? It seems there is very few changes to make before being able to merge it into master.

[markreidvfx]

Sorry, I got really busy and must have forgotten about this. I'll try and find some time to finish it, just have too many ongoing projects at the moment. If anyone want to take it over, feel free too.