Add StartTLS functionality #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apart from having an encrypted connection from the start (LDAPS), LDAP also supports using StartTLS: Begin with an unencrypted connection, then update to TLS (see RFC4511 Section 4.14). The go-ldap package already supports this. This commit makes the functionality available to kubernetes-ldap by introducing an additional CLI flag "ldap-starttls". Signed-off-by: Daniel Mohr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from having an encrypted connection from the start (LDAPS),
LDAP also supports using StartTLS: Begin with an unencrypted
connection, then update to TLS (see RFC4511 Section 4.14).
The go-ldap package already supports this. This commit makes the
functionality available to kubernetes-ldap by introducing an
additional CLI flag "ldap-starttls".
Signed-off-by: Daniel Mohr [email protected]