-
Notifications
You must be signed in to change notification settings - Fork 84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start! I made one suggestion and in order for this to work on the site, the link needs to be included in the whiteboard.html
file.
If that was confusing in the guide, we'd love a Pull Request or Issue with ideas for how we might be able to clear that up.
Thank you!
<input type="checkbox" id="sum-strings-answer"> | ||
<label for="sum-strings-answer">Click to see an answer written in Python</label> | ||
<div class="content"> | ||
<script src="https://gist.github.com/ziyadedher/0cf0a6f608dc57896b28f6dae42bba2c.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this solution, this seems like a pretty advanced solution that might be confusing for newcomers. It might be good to make a simpler solution that gets linked here as well as another section called Advanced Approach
which would include a more sophisticated answer like this?
Updated the PR, check it out! |
Yes! This is great! Can you update the |
Can't believe I missed those, sorry! |
No problem! It might be good to add that to the guide that we have on our README (you're not the only one to make that mistake). If you want to create an issue for it, that would be amazing! Otherwise, thank you so much for your contribution! |
#29