Ask for the push API key again when validation fails #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's just common courtesy.
Using `@cached_property` to define these prompting functions (which are, fundamentally, not really properties at all) makes it a lot harder to reason about what happens when you invoke them. Furthermore, as far as I'm aware, there's no documented way to clear the cache for a cached property. This change is, in the wise words of Mickey Mouse, "a surprise tool that will help us later".
If the push API key does not validate, ask for it again instead of kicking the user out of the installer. Move the logic out of the install command and to its own function. Spice it up with some emojis (they're free!)
Handle unexpected validation errors, such as AppSignal's servers not being reachable.
|
Hi @unflxw, We've found some issues with your Pull Request.
|
unflxw
force-pushed
the
try-validate-api-key-again
branch
from
e492015 to
1b55359
Compare
unflxw
changed the title
Make it so that the `mock_input` context manager can indicate the expectation of an unanswered prompt by using `None` instead of an answer. When this happens, the expected `StopIteration` that indicates that a prompt was asked for which no answer was given is not raised as an error. Delete several duplicates of `mock_input` and move it to a single `utils.py` file.
unflxw
force-pushed
the
try-validate-api-key-again
branch
from
1b55359 to
4544c88
Compare
luismiramirez
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greet before asking questions
It's just common courtesy.
Do not use @cached_property for prompts
Using
@cached_propertyto define these prompting functions (whichare, fundamentally, not really properties at all) makes it a lot
harder to reason about what happens when you invoke them. Furthermore,
as far as I'm aware, there's no documented way to clear the cache for
a cached property.
This change is, in the wise words of Mickey Mouse, "a surprise tool
that will help us later".
Ask for the push API key again if it's invalid
If the push API key does not validate, ask for it again instead of
kicking the user out of the installer.
Move the logic out of the install command and to its own function.
Spice it up with some emojis (they're free!)
Handle unexpected validation errors
Handle unexpected validation errors, such as AppSignal's servers
not being reachable.
Test asking again for API key
Make it so that the
mock_inputcontext manager can indicate theexpectation of an unanswered prompt by using
Noneinstead of ananswer.
When this happens, the expected
StopIterationthat indicates thata prompt was asked for which no answer was given is not raised as an
error.
Delete several duplicates of
mock_inputand move it to a singleutils.pyfile.