Fix owner leak in destroy_shape()
#344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that lingering owner references are cleared after a shape is destroyed by adding a call to `clear()` on the `owners` HashMap.
Ughuuu
approved these changes
Feb 20, 2025
|
Odd that after a shape is destroyed it is still used? |
|
Forgot to mention, tested the PR's build on my project and the issue is gone so I assume that was it. |
|
Sorry for delay, got busy with other stuff. Merged it now. |
|
No worries, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that lingering owner references are cleared after a shape is destroyed by adding a call to
clear()on theownersHashMap.Fixes #266.