fix: added null checks for message.data & pong type checking #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
reviewed
Jan 23, 2025
templates/android/library/src/main/java/io/package/services/Realtime.kt.twig
Show resolved
Hide resolved
loks0n
reviewed
Jan 24, 2025
loks0n
reviewed
Jan 24, 2025
loks0n
approved these changes
Jan 27, 2025
templates/android/library/src/main/java/io/package/services/Realtime.kt.twig
Outdated
Show resolved
Hide resolved
christyjacob4
approved these changes
Jan 27, 2025
Co-authored-by: Christy Jacob <[email protected]>
Co-authored-by: Christy Jacob <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
During creation of heartbeat messages in realtime, the response is
{"type": "pong"}. It does not contain thedataattribute that the code does not account for, leading to error:This PR adds null-safety checks for message event type in flutter, android, ios, web and react-native. it also makes accounting for
pongtype consistent.Test Plan
Related PRs and Issues
type 'Null' is not a subtype of type 'Map<dynamic, dynamic>'exception #1026Have you read the Contributing Guidelines on issues?
Yes.