-
Notifications
You must be signed in to change notification settings - Fork 109
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
AIP-X Increase coin symbol limit to 32 bytes (#558)
* Fix typos in template * [aip] Add AIP to increase coin symbol length * Update and rename aip-increase-coin-symbol.md to aip-114.md --------- Co-authored-by: Frances Liu <[email protected]>
- Loading branch information
1 parent
5b10df0
commit 6d07d61
Showing
2 changed files
with
72 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
--- | ||
aip: 114 | ||
title: Increase Coin Symbol Length | ||
author: <a list of the author's or authors' name(s) and/or username(s), or name(s) and email(s). Details are below.> | ||
discussions-to (*optional): <a url pointing to the official discussion thread> | ||
Status: Draft | ||
last-call-end-date (*optional): <mm/dd/yyyy the last date to leave feedbacks and reviews> | ||
type: Standard (Framework) | ||
created: 02/01/2024 | ||
updated (*optional): <mm/dd/yyyy> | ||
requires (*optional): <AIP number(s)> | ||
--- | ||
|
||
# AIP-114 - Increase Coin Symbol Byte Length | ||
|
||
## Summary | ||
|
||
Currently, emojis are 3 bytes, and could be longer up to 32 bytes. This AIP proposes to increase the coin and FA symbol | ||
byte length to allow for more combinations of emojis to be used as a coin symbol. This is an increase behind a feature | ||
flag to increase from 10 bytes to 32 bytes, and will need to adjust the indexer storage accordingly. | ||
|
||
Goal here is to allow for more flexibility in coin symbols, and to allow for more unique coin symbols to be used. | ||
|
||
### Out of scope | ||
|
||
> What are we committing to not doing and why are they scoped out? | ||
Not changing anything but the number of bytes allowed to be stored, and the Aptos default indexer. | ||
|
||
## High-level Overview | ||
|
||
Increases the limit to 32 bytes, adds a feature flag to enable this, and adjusts the indexer storage to allow for this. | ||
|
||
## Impact | ||
|
||
Indexers will now need to handle the longer symbol length. Most other applications simply read, and should not have any | ||
issues with this change. | ||
|
||
If this proposal doesn't happen, then we will be limited to 10 bytes for coin and FA symbols. | ||
|
||
## Alternative Solutions | ||
|
||
None, it's currently limited to 10 bytes, there's no other way to stick with UTF-8 and allow for more emojis. | ||
|
||
## Specification and Implementation Details | ||
|
||
See https://github.com/aptos-labs/aptos-core/pull/15846 | ||
|
||
## Reference Implementation | ||
|
||
Has a feature flag associated. See https://github.com/aptos-labs/aptos-core/pull/15846 | ||
|
||
## Testing | ||
|
||
Will have to test in devnet / testnet against existing indexers to ensure they can handle the longer symbol length. | ||
|
||
## Risks and Drawbacks | ||
|
||
Risk is some indexers may not be able to handle the longer symbol length, and may need to be updated. This could break | ||
existing indexers that handle generic types, but should not effect indexers for things like centralized exchanges. | ||
|
||
## Security Considerations | ||
|
||
None | ||
|
||
## Future Potential | ||
|
||
None |