Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brian/temp 5eefd205fe #15705

Draft
wants to merge 21 commits into
base: brian/exec-window-exec-optimize-2
Choose a base branch
from

Conversation

bchocho
Copy link
Contributor

@bchocho bchocho commented Jan 10, 2025

  • [execution-pool] Add window and block retrieval to block_tree, block_store and persistent_liveness_storage.
  • [execution-pool] Remove round manager test assertion
  • [execution-pool] Add consensus config v4
  • [execution-pool] Update consensus.yaml for target_block_and_round
  • Execute the block window. Doesn't have any optimizations.
  • [NOT FOR MAIN] turn off consensus observer
  • Filter committed transactions. Up until round-1 in prepare phase, and round-1 in execution phase. This requires using blocking txn provider to quickly provide shuffled txns in the execution phase.
  • incremental update of duplicate counts
  • Remove QS backpressure
  • reinstate max_txns_to_execute
  • filter expired txns
  • execution backpressure with block gas limit
  • fix waiting for window prepare vs execute
  • prototype integration in gas meter
  • use average instead of median
  • Don't use block if gas used is less than the min block gas limit
  • spread more
  • re-instate quorum store backpressure
  • naive? attempt at removing txns from proof manager on commit
  • ordered / unordered caches
  • Revert "naive? attempt at removing txns from proof manager on commit"
  • reduce backlog
  • reduce further
  • add a constant 10ms

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jan 10, 2025

⏱️ 26m total CI duration on this PR
Job Cumulative Duration Recent Runs
test-target-determinator 18m 🟩🟩🟥🟩
determine-test-metadata 6m 🟩🟩🟩🟩
file_change_determinator 44s 🟩🟩🟩🟩
permission-check 14s 🟩🟩🟩🟩🟩
permission-check 13s 🟩🟩🟩🟩
permission-check 13s 🟩🟩🟩🟩🟩
generate-matrix 11s 🟩🟩🟩🟩
determine-docker-build-metadata 11s 🟩🟩🟩🟩
check-branch-prefix 1s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@bchocho bchocho changed the base branch from main to brian/exec-window-exec-optimize-2 January 10, 2025 05:54
@bchocho bchocho added the CICD:build-images when this label is present github actions will start build+push rust images from the PR. label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:build-images when this label is present github actions will start build+push rust images from the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants