Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary code #15731

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gregnazario
Copy link
Contributor

@gregnazario gregnazario commented Jan 14, 2025

Description

This removes a bunch of legacy folders and things that are not used. I suspect it to fail in CI, but will iterate to cleanup the remaining unused CI items.

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@gregnazario gregnazario requested a review from banool as a code owner January 14, 2025 19:38
Copy link

trunk-io bot commented Jan 14, 2025

⏱️ 5m total CI duration on this PR
Job Cumulative Duration Recent Runs
check-dynamic-deps 2m 🟩
rust-cargo-deny 2m 🟩
general-lints 25s 🟩
semgrep/ci 25s 🟩
file_change_determinator 13s 🟩
permission-check 2s 🟩
permission-check 2s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant