Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[primary_fungible_store] fix miswording #15767

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0xbe1
Copy link
Contributor

@0xbe1 0xbe1 commented Jan 17, 2025

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jan 17, 2025

⏱️ 14m total CI duration on this PR
Job Cumulative Duration Recent Runs
test-target-determinator 5m 🟩
check-dynamic-deps 5m 🟩
rust-cargo-deny 2m 🟩
fetch-last-released-docker-image-tag 2m 🟩
general-lints 31s 🟩
semgrep/ci 26s 🟩
file_change_determinator 13s 🟩
file_change_determinator 10s 🟩
permission-check 5s 🟥🟩
permission-check 4s 🟥🟩
permission-check 2s 🟩
determine-docker-build-metadata 2s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@gregnazario gregnazario enabled auto-merge (squash) January 17, 2025 06:40

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 5a9483b1ad0c212964ac5db6938aa5f4846ad382

two traffics test: inner traffic : committed: 14898.75 txn/s, latency: 2665.63 ms, (p50: 2400 ms, p70: 2700, p90: 3300 ms, p99: 5400 ms), latency samples: 5664840
two traffics test : committed: 99.96 txn/s, latency: 1398.16 ms, (p50: 1300 ms, p70: 1300, p90: 1400 ms, p99: 5700 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.439, avg: 1.205", "ConsensusProposalToOrdered: max: 0.299, avg: 0.290", "ConsensusOrderedToCommit: max: 0.334, avg: 0.322", "ConsensusProposalToCommit: max: 0.621, avg: 0.613"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.19s no progress at version 28902 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.52s no progress at version 2867569 (avg 0.52s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 6593fb81261f25490ffddc2252a861c994234c2a ==> 5a9483b1ad0c212964ac5db6938aa5f4846ad382

Compatibility test results for 6593fb81261f25490ffddc2252a861c994234c2a ==> 5a9483b1ad0c212964ac5db6938aa5f4846ad382 (PR)
1. Check liveness of validators at old version: 6593fb81261f25490ffddc2252a861c994234c2a
compatibility::simple-validator-upgrade::liveness-check : committed: 18465.94 txn/s, latency: 1907.86 ms, (p50: 2000 ms, p70: 2100, p90: 2100 ms, p99: 2200 ms), latency samples: 590900
2. Upgrading first Validator to new version: 5a9483b1ad0c212964ac5db6938aa5f4846ad382
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5198.69 txn/s, latency: 5775.74 ms, (p50: 6700 ms, p70: 6900, p90: 7400 ms, p99: 7600 ms), latency samples: 104360
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5070.67 txn/s, latency: 6817.35 ms, (p50: 7400 ms, p70: 7400, p90: 7500 ms, p99: 7800 ms), latency samples: 177960
3. Upgrading rest of first batch to new version: 5a9483b1ad0c212964ac5db6938aa5f4846ad382
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4949.48 txn/s, latency: 6235.55 ms, (p50: 7000 ms, p70: 7600, p90: 7900 ms, p99: 8000 ms), latency samples: 98480
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5021.35 txn/s, latency: 6858.77 ms, (p50: 7600 ms, p70: 7700, p90: 7900 ms, p99: 8000 ms), latency samples: 176440
4. upgrading second batch to new version: 5a9483b1ad0c212964ac5db6938aa5f4846ad382
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8881.92 txn/s, latency: 3467.65 ms, (p50: 4000 ms, p70: 4200, p90: 4400 ms, p99: 4600 ms), latency samples: 159600
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8852.49 txn/s, latency: 3858.89 ms, (p50: 4200 ms, p70: 4300, p90: 4500 ms, p99: 4600 ms), latency samples: 290720
5. check swarm health
Compatibility test for 6593fb81261f25490ffddc2252a861c994234c2a ==> 5a9483b1ad0c212964ac5db6938aa5f4846ad382 passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants