Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] add package manager installation method #15768

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Xeonacid
Copy link

@Xeonacid Xeonacid commented Jan 17, 2025

Description

If the binary locates at /usr/bin, refuse to use aptos update aptos, and redirect to package manager.

How Has This Been Tested?

  • cargo build --release -p aptos with a old version patched like 6.0.0
  • sudo mv target/release/aptos /usr/bin/aptos
  • aptos update aptos

Key Areas to Review

This might be merged with the brew method.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

If the binary locates at /usr/bin, refuse to use `aptos update aptos`,
and redirect to package manager.

This might be merged with the brew method.
Copy link

trunk-io bot commented Jan 17, 2025

⏱️ 5s total CI duration on this PR

Job Cumulative Duration Recent Runs
permission-check 3s 🟥
permission-check 2s 🟥

settingsfeedbackdocs ⋅ learn more about trunk.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant