Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add edge cases for indexer fa and token-v2 tests #15782

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

yuunlimm
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jan 21, 2025

⏱️ 34m total CI duration on this PR
Job Cumulative Duration Recent Runs
check-dynamic-deps 7m 🟩🟩🟩
dispatch_event 6m 🟥
dispatch_event 6m 🟥
dispatch_event 6m 🟥
rust-cargo-deny 5m 🟩🟩🟩
general-lints 1m 🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 30s 🟩🟩🟩
permission-check 9s 🟩🟩🟩
permission-check 7s 🟩🟩🟩
check-branch-prefix 1s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yuunlimm yuunlimm force-pushed the 01-21-add_edge_cases_for_indexer_fa_and_token-v2_tests branch 2 times, most recently from 0db6d05 to 63eb894 Compare January 27, 2025 19:08
@yuunlimm yuunlimm marked this pull request as ready for review January 27, 2025 19:18
@yuunlimm yuunlimm requested a review from a team January 27, 2025 21:25
Copy link
Contributor

rtso commented Jan 27, 2025

hmm the Processor Tests run failed, wrong auth token? @yuunlimm @larry-aptos

@larry-aptos
Copy link
Contributor

is this from the deletion of token in github? @yuunlimm

@yuunlimm
Copy link
Contributor Author

is this from the deletion of token in github? @yuunlimm
I updated the token but it seems like that token is removed as well. tested locally and it didn't work. let me update this with the new one

@yuunlimm yuunlimm force-pushed the 01-21-add_edge_cases_for_indexer_fa_and_token-v2_tests branch from 63eb894 to 524229b Compare January 31, 2025 05:59
@yuunlimm yuunlimm enabled auto-merge (squash) January 31, 2025 06:26

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 524229bde5cb5a683c8e0343741e9d73dd31a74e

two traffics test: inner traffic : committed: 14852.74 txn/s, submitted: 14860.48 txn/s, expired: 7.73 txn/s, latency: 2642.79 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3200 ms), latency samples: 5647380
two traffics test : committed: 99.99 txn/s, latency: 1365.48 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 1900 ms), latency samples: 2020
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.414, avg: 1.369", "ConsensusProposalToOrdered: max: 0.290, avg: 0.287", "ConsensusOrderedToCommit: max: 0.434, avg: 0.413", "ConsensusProposalToCommit: max: 0.724, avg: 0.700"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.20s no progress at version 39530 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.78s no progress at version 6360810 (avg 0.69s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 60f7ca8827f5d64a148c3b163dc4126b0879279b ==> 524229bde5cb5a683c8e0343741e9d73dd31a74e

Compatibility test results for 60f7ca8827f5d64a148c3b163dc4126b0879279b ==> 524229bde5cb5a683c8e0343741e9d73dd31a74e (PR)
1. Check liveness of validators at old version: 60f7ca8827f5d64a148c3b163dc4126b0879279b
compatibility::simple-validator-upgrade::liveness-check : committed: 11966.30 txn/s, latency: 2557.16 ms, (p50: 2500 ms, p70: 2800, p90: 3400 ms, p99: 4300 ms), latency samples: 412820
2. Upgrading first Validator to new version: 524229bde5cb5a683c8e0343741e9d73dd31a74e
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3661.81 txn/s, latency: 8216.42 ms, (p50: 8900 ms, p70: 9900, p90: 10600 ms, p99: 10800 ms), latency samples: 80380
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3962.43 txn/s, latency: 8602.65 ms, (p50: 9400 ms, p70: 9800, p90: 10000 ms, p99: 10200 ms), latency samples: 139720
3. Upgrading rest of first batch to new version: 524229bde5cb5a683c8e0343741e9d73dd31a74e
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4233.59 txn/s, latency: 7382.79 ms, (p50: 8100 ms, p70: 8900, p90: 9200 ms, p99: 9300 ms), latency samples: 90940
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4187.18 txn/s, latency: 8130.04 ms, (p50: 9100 ms, p70: 9300, p90: 9600 ms, p99: 9600 ms), latency samples: 147040
4. upgrading second batch to new version: 524229bde5cb5a683c8e0343741e9d73dd31a74e
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 7593.88 txn/s, latency: 4021.14 ms, (p50: 4200 ms, p70: 4500, p90: 5700 ms, p99: 5900 ms), latency samples: 138260
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7484.93 txn/s, latency: 4509.26 ms, (p50: 4300 ms, p70: 5600, p90: 5900 ms, p99: 6400 ms), latency samples: 256300
5. check swarm health
Compatibility test for 60f7ca8827f5d64a148c3b163dc4126b0879279b ==> 524229bde5cb5a683c8e0343741e9d73dd31a74e passed
Test Ok

@yuunlimm yuunlimm disabled auto-merge January 31, 2025 06:57
@yuunlimm yuunlimm merged commit f246671 into main Jan 31, 2025
88 of 89 checks passed
Copy link
Contributor Author

Merge activity

  • Jan 31, 2:05 AM EST: A user merged this pull request with Graphite.

@yuunlimm yuunlimm deleted the 01-21-add_edge_cases_for_indexer_fa_and_token-v2_tests branch January 31, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants