Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spec] Clean permissioned_signer spec #15850

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rahxephon89
Copy link
Contributor

Description

This PR makes check_permission_consume and capacity spec opaque to further reduce memory usage from 30GB to 7GB.

How Has This Been Tested?

Existing spec tests

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Spec

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jan 30, 2025

⏱️ 6m total CI duration on this PR
Job Cumulative Duration Recent Runs
check-dynamic-deps 3m 🟩
rust-cargo-deny 2m 🟩
semgrep/ci 28s 🟩
general-lints 24s 🟩
file_change_determinator 10s 🟩
permission-check 3s 🟩
permission-check 2s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@rahxephon89 rahxephon89 changed the title [WIP][spec] Clean permissioned_signer spec [spec] Clean permissioned_signer spec Jan 30, 2025
@rahxephon89 rahxephon89 requested a review from vineethk January 30, 2025 20:26
@rahxephon89 rahxephon89 marked this pull request as ready for review January 30, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants