[api] Add signature_type to AccountSignature #15926
Open
+172
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For a while, it's hard to tell what the underlying type of each signature is. Now, it adds a non-conflicting type to determine it.
Note that, this change currently breaks the existing OpenAPI spec documentation, but will still work with the old information.
How Has This Been Tested?
I tested this manually against many of the different types of transactions in the API, to see how they would show up in the explorer. Here are some examples:
Single key, with ed25519:
Single key, with secp256k1:
Abstraction:
Ed25519 (original):
MultiKey:
Multiagent with single signers in it
Fee payer
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist