Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] Remove module generation #15930

Merged
merged 1 commit into from
Feb 12, 2025
Merged

[cleanup] Remove module generation #15930

merged 1 commit into from
Feb 12, 2025

Conversation

vineethk
Copy link
Contributor

@vineethk vineethk commented Feb 11, 2025

Description

In this PR, we remove the now defunct module generation.

How Has This Been Tested?

Existing tests.

Type of Change

  • Refactoring

Copy link

trunk-io bot commented Feb 11, 2025

⏱️ 2h 42m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 49m 🟩🟩
rust-targeted-unit-tests 26m 🟩
check-dynamic-deps 23m 🟩🟩🟩🟩🟩 (+4 more)
rust-images / rust-all 16m 🟩
execution-performance / test-target-determinator 9m 🟩🟩
rust-cargo-deny 9m 🟩🟩🟩🟩 (+1 more)
test-target-determinator 8m 🟩🟩
rust-doc-tests 6m 🟩
rust-doc-tests 5m 🟩
semgrep/ci 3m 🟩🟩🟩🟩🟩 (+4 more)
fetch-last-released-docker-image-tag 3m 🟩🟩
general-lints 2m 🟩🟩🟩🟩 (+1 more)
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+1 more)
file_change_determinator 28s 🟩🟩
permission-check 24s 🟩🟩🟩🟩🟩 (+4 more)

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
test-target-determinator 4m 5m -29%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

vineethk commented Feb 11, 2025

@vineethk vineethk changed the base branch from vk/tp-cleanup-1 to graphite-base/15930 February 11, 2025 22:31
@vineethk vineethk force-pushed the graphite-base/15930 branch 2 times, most recently from 71479a9 to 875e812 Compare February 12, 2025 02:03
@vineethk vineethk force-pushed the graphite-base/15930 branch from 875e812 to c956c32 Compare February 12, 2025 16:59
@vineethk vineethk changed the base branch from graphite-base/15930 to main February 12, 2025 16:59
@vineethk vineethk enabled auto-merge (squash) February 12, 2025 17:00

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 50ac94bca3cb2eafc48664f5cef84fc38eb22fa1

two traffics test: inner traffic : committed: 10445.62 txn/s, submitted: 10451.56 txn/s, expired: 5.94 txn/s, latency: 3732.73 ms, (p50: 3000 ms, p70: 3300, p90: 3700 ms, p99: 31700 ms), latency samples: 3971682
two traffics test : committed: 99.99 txn/s, latency: 1585.02 ms, (p50: 1500 ms, p70: 1600, p90: 1700 ms, p99: 3500 ms), latency samples: 1840
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.264, avg: 1.990", "ConsensusProposalToOrdered: max: 0.370, avg: 0.358", "ConsensusOrderedToCommit: max: 0.568, avg: 0.522", "ConsensusProposalToCommit: max: 0.922, avg: 0.881"]
Max non-epoch-change gap was: 1 rounds at version 30453 (avg 0.00) [limit 4], 2.02s no progress at version 30453 (avg 0.25s) [limit 15].
Max epoch-change gap was: 1 rounds at version 957902 (avg 0.50) [limit 4], 2.31s no progress at version 957902 (avg 1.51s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 50ac94bca3cb2eafc48664f5cef84fc38eb22fa1

Compatibility test results for 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 50ac94bca3cb2eafc48664f5cef84fc38eb22fa1 (PR)
Upgrade the nodes to version: 50ac94bca3cb2eafc48664f5cef84fc38eb22fa1
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1606.76 txn/s, submitted: 1611.64 txn/s, failed submission: 4.89 txn/s, expired: 4.89 txn/s, latency: 1764.78 ms, (p50: 1600 ms, p70: 1900, p90: 2500 ms, p99: 3800 ms), latency samples: 144720
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1757.49 txn/s, submitted: 1764.15 txn/s, failed submission: 6.67 txn/s, expired: 6.67 txn/s, latency: 1622.09 ms, (p50: 1500 ms, p70: 1800, p90: 2400 ms, p99: 4100 ms), latency samples: 158140
5. check swarm health
Compatibility test for 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 50ac94bca3cb2eafc48664f5cef84fc38eb22fa1 passed
Upgrade the remaining nodes to version: 50ac94bca3cb2eafc48664f5cef84fc38eb22fa1
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1474.12 txn/s, submitted: 1479.40 txn/s, failed submission: 5.28 txn/s, expired: 5.28 txn/s, latency: 1919.93 ms, (p50: 1800 ms, p70: 2100, p90: 2700 ms, p99: 4000 ms), latency samples: 134060
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 50ac94bca3cb2eafc48664f5cef84fc38eb22fa1

Compatibility test results for 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 50ac94bca3cb2eafc48664f5cef84fc38eb22fa1 (PR)
1. Check liveness of validators at old version: 255673e8f2757ed8634a7d65d7aca11de7016cde
compatibility::simple-validator-upgrade::liveness-check : committed: 11565.67 txn/s, latency: 2697.04 ms, (p50: 2500 ms, p70: 2700, p90: 3600 ms, p99: 7100 ms), latency samples: 400940
2. Upgrading first Validator to new version: 50ac94bca3cb2eafc48664f5cef84fc38eb22fa1
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 2945.51 txn/s, latency: 9969.02 ms, (p50: 10700 ms, p70: 12100, p90: 12800 ms, p99: 13000 ms), latency samples: 65360
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3154.56 txn/s, latency: 10909.02 ms, (p50: 11900 ms, p70: 12300, p90: 12400 ms, p99: 12500 ms), latency samples: 123580
3. Upgrading rest of first batch to new version: 50ac94bca3cb2eafc48664f5cef84fc38eb22fa1
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 980.57 txn/s, submitted: 980.86 txn/s, expired: 0.29 txn/s, latency: 8919.25 ms, (p50: 9500 ms, p70: 10700, p90: 11400 ms, p99: 11600 ms), latency samples: 73918
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3239.63 txn/s, latency: 10650.61 ms, (p50: 11600 ms, p70: 11800, p90: 11900 ms, p99: 12000 ms), latency samples: 126620
4. upgrading second batch to new version: 50ac94bca3cb2eafc48664f5cef84fc38eb22fa1
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 5621.62 txn/s, latency: 5324.60 ms, (p50: 5900 ms, p70: 6300, p90: 7400 ms, p99: 7800 ms), latency samples: 109540
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 5822.77 txn/s, latency: 5907.26 ms, (p50: 6000 ms, p70: 6800, p90: 7400 ms, p99: 7600 ms), latency samples: 200560
5. check swarm health
Compatibility test for 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 50ac94bca3cb2eafc48664f5cef84fc38eb22fa1 passed
Test Ok

@vineethk vineethk merged commit 0da1d84 into main Feb 12, 2025
46 checks passed
@vineethk vineethk deleted the vk/tp-cleanup-2 branch February 12, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants