Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix execution concurrency level for single-core systems #15932

Closed
wants to merge 3 commits into from

Conversation

zi0Black
Copy link
Contributor

Description

Small check for emulated environments where we can have a single CPU core.
@JoshLind if you prefer a one line we can update this.

How Has This Been Tested?

N/A

Key Areas to Review

N/A

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@zi0Black zi0Black requested a review from JoshLind as a code owner February 11, 2025 14:06
Copy link

trunk-io bot commented Feb 11, 2025

⏱️ 21m total CI duration on this PR
Job Cumulative Duration Recent Runs
check-dynamic-deps 10m 🟩🟩🟩🟩
rust-cargo-deny 7m 🟩🟩🟩🟩
general-lints 2m 🟩🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩
file_change_determinator 48s 🟩🟩🟩🟩
permission-check 8s 🟩🟩🟩🟩
permission-check 7s 🟩🟩🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io


let mut backoff_ms = INITIAL_BACKOFF_MS;

for attempt in 0..=MAX_RETRIES {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The range 0..=MAX_RETRIES is inclusive and will result in 4 attempts (0,1,2,3). To match the intended MAX_RETRIES value of 3, consider using 0..MAX_RETRIES instead, which will perform exactly 3 attempts.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@zi0Black zi0Black closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant