[compiler-v2] Perform check of uninitialized locals in code spec blocks #15943
+123
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 10m total CI duration on this PR
|
rahxephon89
changed the title
rahxephon89
changed the title
vineethk
approved these changes
Feb 13, 2025
| }); | ||
| }; | ||
| if let Bytecode::SpecBlock(_, spec) = bc { | ||
| for cond in &spec.conditions { |
There was a problem hiding this comment.
Is conditions the only field of spec that needs to be checked? How about update_map?
There was a problem hiding this comment.
Yes, update_map is not yet filled in this phase AFAIK. The test case with update z = y; is used to show it.
There was a problem hiding this comment.
Maybe we can just say that in a comment here, so that it is explicit to the reader.
rahxephon89
force-pushed
the
teng/fix-15928
branch
from
2b547dc to
036d388
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds checking of uninitialized locals in the spec block.
close #15928
How Has This Been Tested?
Key Areas to Review
Whether the fix covers all cases for spec blocks.
Type of Change
Which Components or Systems Does This Change Impact?
Checklist